AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Jobi.Ariyamannil@lsi.com>,<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	5D3F3304755C724285AA5789BA159920BABF6CAE@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 22 Jan 2010 15:04:49 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Ariyamannil, Jobi" <Jobi.Ariyamannil@lsi.com>
Cc: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: PERFORCE change 34241 for review
Message-ID: <20100122150449.32c6b02f@ripper.onstor.net>
In-Reply-To: <5D3F3304755C724285AA5789BA159920BABF6CAE@cosmail03.lsi.com>
References: <WEBMAILkyTTi1279XIf00106082@mail.onstor.com>
	<20100122121237.0e2eebde@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755EB50C3C9@cosmail02.lsi.com>
	<5D3F3304755C724285AA5789BA159920BABF6CAE@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 22 Jan 2010 14:48:19 -0700 "Ariyamannil, Jobi"
<Jobi.Ariyamannil@lsi.com> wrote:

> I moved my code base from that point.  I will add p4 change number in
> future integrations.  For what it is worth, the timestamp of the
> checkin should give some indication of the state of the dev tree.
> 
> Instead of having different expectations for the check in comments,
> it is good to define and publish the policies of what the developers
> supposed to do. I don't see any big reason for somebody to worry
> about the integrations being done between dev and tuxfs branch (at
> least that was my impression).  It is better to communicate to people
> if there are some rules to be followed, instead of blaming afterwards.

For the record, that's what I was doing.

> Regards,
> Jobi
> 
> -----Original Message-----
> From: Scheer, Larry 
> Sent: Friday, January 22, 2010 12:19 PM
> To: Sharp, Andy; Ariyamannil, Jobi
> Cc: Greiveldinger, Chris; Olien, David; Phelps, David; Upendran, Ram;
> Chandra, Svati; Kodiganti, Siva; Revitch, Sam; Ketineni, Usha
> Subject: RE: PERFORCE change 34241 for review
> 
> Jobi,
>    Andy has a point... Would you please add the change that was the
> top of the dev tree when you integrated the change. You can do this
> with p4 change -u <change#>
> 
> To find the change# that is the top of the dev tree (if haven't
> sync'd it since the integration) do the following
> 
> cd dev
> p4 changes -m1 ./...@$P4CLIENT
> 
> Even if this is branch is your playground it is good to have that
> info immediately available to the casual observer.
> 
> Larry
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Friday, January 22, 2010 12:12 PM
> To: Ariyamannil, Jobi; Ariyamannil, Jobi
> Cc: Greiveldinger, Chris; Olien, David; Phelps, David; Scheer, Larry;
> Upendran, Ram; Chandra, Svati; Kodiganti, Siva; Revitch, Sam;
> Ketineni, Usha Subject: Re: PERFORCE change 34241 for review
> 
> On Thu, 21 Jan 2010 13:35:00 -0700 Jobi Ariyamannil
> <jobi.ariyamannil@lsi.com> wrote:
> 
> > Change 34241 by jobia@jobi:jobi on 2010/01/21 12:33:42
> >
> >            Integrate changes from dev tree.
> >
> >            Reviewed by LarryS.
> >
> 
> Both of y'all know better.  You need to describe what the changes are,
> what changelists they came from, etc.  For shame.
> 
> > Affected files ...
> >
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-am.c#7 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-am.h#3 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-api.h#7 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-buf.c#8 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-debug.c#11 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-dir.c#6 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-dump.c#4 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-eek.c#11 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-hash-file.c#4 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-layout.h#10 edit
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-link.c#5 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-mount.c#9 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-quota.c#6 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-restore.c#3 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-fs/fs-snap.c#9 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-ndmp/ndmp-data-func.c#2 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-sdm-agent/sdm-agent.c#2 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-simtape/simtape.c#2 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-tape/tape-msg.c#2 integrate
> > ... //depot/tuxfs/nfx-tree/code/sm-testdump/testdump-dump.c#2
