AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<maxim.kozlovsky@lsi.com>,<bill.fisher@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 27 Jan 2010 17:10:26 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Maxim Kozlovsky <maxim.kozlovsky@lsi.com>
Cc: Bill Fisher <bill.fisher@lsi.com>
Subject: review of changelist 33991
Message-ID: <20100127171026.4f1226c2@ripper.onstor.net>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Finally finished this.  I removed all the "filename -- looks good"
lines because it's just too huge.

In the future, please submit a separate changelist for mass script-based
modifications like char8->int8 and like that, so that the entire
changelist can be reviewed in one glance.

Thanks,

a


Damnit, hit send button instead of menu button.


= Change 33991 by maximk@maximk-13 on 2009/12/08 15:24:49 *pending*
= 
=         fix sm-scsi sm-evm-srvr sm-thread sm-fs sm-esm sm-scsi
=                compilation.
=                Reviewed by bfisher.
= 


fix reviewed by line, and add little more detail, for instance, you edited things like ssc-ssh-kbr, maybe you should explain why.


linux/kernel/linux-mips-2.6/tuxstor-config

     I don't think you meant to include this, for obvious reasons

nfx-tree/Includes/bqueue.h

     this file is dead and moved.  please use the new version.  or move
     new version here and then make changes to it if you need to.

nfx-tree/Includes/nfx-target.h

     i'm sorry, but we have two macros, one is SBM_REV2 and one is
     SBM_REV_2?  now is the time to fix that

nfx-tree/Includes/nfx-types.h

     line 24 the correct way to fix this is to make everything include
     tpl/bqueue.h, or, to move tpl/bqueue.h to Inlcudes.

nfx-tree/Makefile.tuxstor

     line 28, this is not the correct way to do this unless you want each
     of these directories to be a separate kernel module.  we don't want
     a blizzard of separate kernel modules.  a few is OK, but not a dozen.

nfx-tree/Tools/mkesm.pl

     line 786, already commented on

nfx-tree/code/neteee2/eee-app.c

     line 21, already commented on

nfx-tree/code/neteee2/eee-desc.c

     line 16 already commented on

nfx-tree/code/neteee2/eee-init.c

     line ?? already commented on.  i won't mention it from here on out.
     which means some files may be marked "looks good" when in fact
     this needs to be addressed.  i have no problem if you want to
     move bqueue from tpl directory to Includes directory, personally.
     prolly should have done that from the beginning, but then it was
     not tuxstor in the beginning.

nfx-tree/code/neteee2/eee-timer-api.c

     line 634, we don't use this silliness any more.  rtczero is just 0.

nfx-tree/code/neteee2/eee-timer-api.h

     line 113 see previous comment

nfx-tree/code/neteee2/eee.h

     i'd rather that this sort of thing was in each individual file that
     required it.

nfx-tree/code/sm-bcm5632/bcm5632-port.h

     this file is slated to be deleted.  but hey, whatever.

nfx-tree/code/sm-cifs/cs-struct.h

     i like it

nfx-tree/code/sm-dcache/dcache-api.c

     line 4418 uh, i guess you changed this to BSD_?  fine by me.

nfx-tree/code/sm-dp83820/dp83820.c

     line 348 just delete the whole ifndef, since it's irrelevant
     to tuxstor

     line 380 ditto

     never mind this file will be deleted shortly anyway

nfx-tree/code/sm-esm/Makefile

     ok

nfx-tree/code/sm-esm/esm-nfx.c

     line 58 if the NFX_SPIN_LOCK macro is defined correctly, then
     this change is not needed

nfx-tree/code/sm-evm-srvr/Makefile

     ok

nfx-tree/code/sm-evm-srvr/evm-msg.c

     ok

nfx-tree/code/sm-fs/Makefile

     this definitely doesn't look right to me.  i realize that
     there might be some makefiles that have this dual mode, that
     will be going away since we won't be doing a separate tuxrx
     and tuxfp projects.  also, this will build the sm-fs directory
     as a separate kernel module, which i doubt is what you want.
     the rules for the generated code should be like real makefile
     rules, not just a list of identical rules, one for each file.

nfx-tree/code/sm-fs/btree/bt.h

     ok

nfx-tree/code/sm-fs/btree/emaproot.c

     line 776 FS_ELOG()/FS_TRACE() hasn't been ported over to the
     "no-extra-paren" format?

nfx-tree/code/sm-fs/fs-alloc.c

     line 2934 ... nice

nfx-tree/code/sm-fs/fs-eek-quota.c

     line 1089 don't you want to make these printks?  there are several
     others as well.

nfx-tree/code/sm-fs/fs-eek.c

     line 8628 i just noticed that you're using .counter all over the
     place (in this and several other files) to directly peek/poke
     at the value of an atomic_t.  you're not supposed to do that,
     you're supposed to use that atomic_read() and atomic_set() methods.
     i realize that these are just #define's in mips (they are inlines
     in x86), but they can change the implementation and only have to
     support the access methods, not the structure definition.

nfx-tree/code/sm-fs/restore/restore.c

     line 39, this is silly.  please adopt the use of the <>.

nfx-tree/code/sm-fs/restore/seccache-api.h

     line 30 this is actually wrong, since the path inside "" is
     relative to the file the does the including, not the header file.
     switch to the <> syntax please.  especially for header files.
     you won't have to mess with this stuff ever again.

nfx-tree/code/sm-fs/restore/tape.c

     line 44 again, use of the angle brackets would eliminate the need
     for this nonsense.  please switch to using that syntax.

nfx-tree/code/sm-fs/restore/utilities.c

     line 39 same as the others.  i won't belabor it anymore so some
     files may have the problem will not be listed.

nfx-tree/code/sm-ispfc/ispfc.c

     line 115 please use the standard kernel methods for reading
     registers (io.h)

nfx-tree/linux.mk

     no, this is only done for ssc build

