AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010DFDEA66@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 29 Jan 2010 14:12:13 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review .8
Message-ID: <20100129141213.286cf09b@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010DFDEA66@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010DFDEA66@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 29 Jan 2010 13:13:12 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34302 by maximk@maximk-5 on 2010/01/29 12:12:11 *pending*
> 
>         Fix sm-scsiio compilation.
>                Change logging to vaargs format.
>                Replace printf with printk.
>                Move variable definitions.
>                Remove references to nfxMySlot/CPU.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-scsiio/Makefile#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-scsiio/scsiio-cg.c#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-scsiio/scsiio-debug.h#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-scsiio/scsiio.c#5 edit


= Change 34302 by maximk@maximk-5 on 2010/01/29 12:12:11 *pending*
= 
= 	Fix sm-scsiio compilation.
= 	       Change logging to vaargs format.
= 	       Replace printf with printk.
= 	       Move variable definitions.
= 	       Remove references to nfxMySlot/CPU.
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-scsiio/Makefile

     looks good

nfx-tree/code/sm-scsiio/scsiio-cg.c

     looks good

nfx-tree/code/sm-scsiio/scsiio-debug.h

     looks good

nfx-tree/code/sm-scsiio/scsiio.c

     line 635 what's going on here with the movement back and forth of
     the header pointer, which you are removing? (one other place too)



