AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>,<Rendell.Fong@lsi.com>,<bill.fisher@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010DFDEDC4@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 1 Feb 2010 11:02:09 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Cc: "Fong, Rendell" <Rendell.Fong@lsi.com>, Bill Fisher
 <bill.fisher@lsi.com>
Subject: Re: elog()
Message-ID: <20100201110209.3c9230f8@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010DFDEDC4@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010DFDEB92@cosmail02.lsi.com>
	<20100129165205.52bea929@ripper.onstor.net>
	<1265043936.24463.204.camel@rendellf>
	<861DA0537719934884B3D30A2666FECC010DFDEDC4@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 1 Feb 2010 11:43:48 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Hello,
> 
> I just have to ask, why are we moving the code? Anything wrong with
> the previous location? The process seems to be kind of random, some
> code moves, some does not, what algorithm are you using to decide to
> move stuff? 

CC'ing Bill on this, maybe he knows.

> Some comments on the code itself below.
> 
> Max
> 
> You should use p4 integrate instead of p4 add to preserve the history.
> You did not merge the dev branch changes to the files. This is what
> happens when you start moving things.


I agree with this, folks, please use integrate when moving things.
This has been somewhat abused up to now.


> Acpu.c:
> 
> 51: E_log_init() should be module initialization function instead of
> being called from acpu thread initialization function
> 
> Elog.c: 
> 
> 2: name does not match
> 
> 30: replace this with NFX_SLOT_NFP_FP, NFX_NFP_TXRX1
> 
> 120, 357, 401: should use GFP_NOWAIT
> 
> 357, 401: cast is redundant
> 
> 125: the error is ignored, we just proceed with configuration
> 
> 225: this function is called during initialization in the current
> code, don't see where this is done in yours.
> 
> You removed e_log_var_pa() but the code still uses it.
> 
> Elog-api.h:
> 
> 188: You changed how the macro behaves, it used to check if the
> logging needs to be done at all before doing the function call for
> the performance reasons. The comment right above the macro, which was
> not changed to conform to the new code, mentions it.
> 
> 
> 
> -----Original Message-----
> From: Rendell Fong [mailto:Rendell.Fong@lsi.com] 
> Sent: Monday, February 01, 2010 9:06 AM
> To: Sharp, Andy
> Cc: Kozlovsky, Maxim
> Subject: Re: elog()
> 
> I have a change list (34033) that will add elog in.  It is 1 of my 4
> change lists waiting on Bill's changes to get submitted first.
> 
> 
> On Fri, 2010-01-29 at 17:52 -0700, Andrew Sharp wrote:
> > On Fri, 29 Jan 2010 17:31:07 -0700 "Kozlovsky, Maxim"
> > <Maxim.Kozlovsky@lsi.com> wrote:
> > 
> > > Did you define this function anywhere? I can't seem to find it.
> > 
> > Ask Rendell, I think he took care of that.  It's got to be
> > *somewhere*, which is what customers say about our log data....
> 
