AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010DFDEAC0@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 1 Feb 2010 16:55:26 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review .12
Message-ID: <20100201165526.3a8803d8@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010DFDEAC0@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010DFDEAC0@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 29 Jan 2010 14:44:09 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34305 by maximk@maximk-5 on 2010/01/29 13:43:40 *pending*
> 
>         fix sm-sanm-dm compilation
>                Replace printf with printk, atol with simple_strtol,
>                remove references to nfxMyCPU/SLot
>                Fix prototypes
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/Makefile#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/sanm-dm-log.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/sanm-dm-main.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/sanm-dm-msg.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/sanm-dm-private.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/sanm-dm-sm-funcs.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/sanm-dm-ui.c#2 edit


= Change 34305 by maximk@maximk-5 on 2010/01/29 13:43:40 *pending*
= 
= 	fix sm-sanm-dm compilation
= 	       Replace printf with printk, atol with simple_strtol, 
= 	       remove references to nfxMyCPU/SLot
= 	       Fix prototypes
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-sanm-dm/Makefile

     looks good

nfx-tree/code/sm-sanm-dm/sanm-dm-log.c

     looks good

nfx-tree/code/sm-sanm-dm/sanm-dm-main.c

     looks good

nfx-tree/code/sm-sanm-dm/sanm-dm-msg.c

     looks good

nfx-tree/code/sm-sanm-dm/sanm-dm-private.h

     looks good

nfx-tree/code/sm-sanm-dm/sanm-dm-sm-funcs.c

     line 122 fmt needs a newline

     line 355 won't work with printk: delete it or change it to use
     sprintf with a buffer

nfx-tree/code/sm-sanm-dm/sanm-dm-ui.c

     looks good

