AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010DFDEAE3@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 1 Feb 2010 17:04:51 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review .13
Message-ID: <20100201170451.593007d0@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010DFDEAE3@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010DFDEAE3@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 29 Jan 2010 15:11:16 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34309 by maximk@maximk-5 on 2010/01/29 14:10:35 *pending*
> 
>         Fix sm-sanm-agent compilation
>                Replace ATOMIC_XXX with atomic64_xxx
>                Change logging format
>                Move variable definitions to beginning of functions
>                Remove references to nfxMySlot/CPU
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/Makefile#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-agent-main.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-agent-msg.c#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-agent-private.h#4
> edit ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-agent-sm-funcs.c#4
> edit ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-agent-ui.c#3
> edit ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-agent-util.c#5
> edit ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/sanm-dmip-funcs.c#6
> edit
> 


= Change 34309 by maximk@maximk-5 on 2010/01/29 14:10:35 *pending*
= 
= 	Fix sm-sanm-agent compilation 
= 	       Replace ATOMIC_XXX with atomic64_xxx
= 	       Change logging format
= 	       Move variable definitions to beginning of functions
= 	       Remove references to nfxMySlot/CPU
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-sanm-agent/Makefile

     looks good

nfx-tree/code/sm-sanm-agent/sanm-agent-main.c

     looks good

nfx-tree/code/sm-sanm-agent/sanm-agent-msg.c

     looks good

nfx-tree/code/sm-sanm-agent/sanm-agent-private.h

     looks good

nfx-tree/code/sm-sanm-agent/sanm-agent-sm-funcs.c

     looks good

nfx-tree/code/sm-sanm-agent/sanm-agent-ui.c

     looks good

nfx-tree/code/sm-sanm-agent/sanm-agent-util.c

     looks good

nfx-tree/code/sm-sanm-agent/sanm-dmip-funcs.c

     looks good

