AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010DFDEB0E@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 1 Feb 2010 17:17:41 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review .17
Message-ID: <20100201171741.31ae9ec4@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010DFDEB0E@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010DFDEB0E@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 29 Jan 2010 15:40:52 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34316 by maximk@maximk-5 on 2010/01/29 14:39:46 *pending*
> 
>         Add new modules
>                change to build all modules with single command
>                                 remove fs-errstr.o to sync with dev
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-evm-srvr/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-fs/Makefile#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-hash/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ispfc/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-scsi/Makefile#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-thread/Makefile#2 edit
> 


= Change 34316 by maximk@maximk-5 on 2010/01/29 14:39:46 *pending*
= 
= 	Add new modules 
= 	       change to build all modules with single command 
= 	       Reviewed by andys.
= 


Comment has trailing white space (tws).  I'm just sayin.





nfx-tree/Makefile.tuxstor

     line 22, won't lines 30-31 change the value of M?


nfx-tree/code/sm-esm/Makefile

     line 4 ug-ly. but hey, if that's what you want.

nfx-tree/code/sm-evm-srvr/Makefile

     looks ugly

nfx-tree/code/sm-fs/Makefile

     i think you can fix line 153...as in delete this paragraph since
     this part is only for SSC, correct?

nfx-tree/code/sm-hash/Makefile

     looks ugly

nfx-tree/code/sm-ispfc/Makefile

     line 4 looks ugly ~:^)

     line 36, we aren't going to be building in sm-sb1250, so, if this
     is the only file left in that directory, then just move it over
     to this directory.

nfx-tree/code/sm-scsi/Makefile

     looks ugly

nfx-tree/code/sm-thread/Makefile

     looks ugly

