AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E06B427@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 4 Feb 2010 14:00:36 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review  .8
Message-ID: <20100204140036.29adab78@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E06B427@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06B3F7@cosmail02.lsi.com>
	<20100204134625.20308c8a@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E06B427@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 4 Feb 2010 14:50:30 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Thursday, February 04, 2010 1:46 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review .8
> 
> On Thu, 4 Feb 2010 14:20:21 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 34382 by maximk@maximk-5 on 2010/02/04 13:19:19 *pending*
> > 
> >         Fix eee_timestamp() definitions.
> >                Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/sibyte/bcm1480/setup.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/eee-timer-api.h#1
> > edit ... //depot/tuxrx/nfx-tree/code/neteee2/eee-timer-api.h#4 edit
> > 
> 
> 
> = Change 34382 by maximk@maximk-5 on 2010/02/04 13:19:19 *pending*
> = 
> = 	Fix eee_timestamp() definitions.
> = 	       Reviewed by andys.
> = 
> 
> linux/kernel/linux-mips-2.6/arch/mips/sibyte/bcm1480/setup.c
> 
>      all this code is scheduled for deletion, but hey, knock yourself
>      out ~:^)
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/eee-timer-api.h
> 
>      i believe this code is redundant -- there is generic kernel code
>      for doing this on the sb1 processors.  we will not only want to
>      use that, but use a generic api on top of it if it doesn't
> already, for when we go to x86
> [MK] what is this code? I have not found any references to
> ZBBUS_CYCLE_COUNT anywhere in the kernel code. 

Start with the file arch/mips/sibyte/Kconfig and look for

SIBYTE_HAS_ZBUS_PROFILING
SIBYTE_TBPROF
SIBYTE_BW_TRACE

and other similar config variables and follow them to the code they
controll.  And let me know what you find, since I've never looked all
that closely at it.  If you want to punt it for now, that's fine too.
Might be a good project for one of those guys up in Beaverton.



> linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/net/tpl/tpl-ipc.c
> 
>      looks good
> 
> nfx-tree/code/neteee2/eee-timer-api.h
> 
>      this file is dead.  i think.  better safe then sorry i guess.
> [MK] Not until Bill checks in his changes, and who knows how long
> that is going to take.

Right.  That's why I said "better safe than sorry".
