AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1265396794.24463.321.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 5 Feb 2010 11:51:08 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 34394
Message-ID: <20100205115108.4147869a@ripper.onstor.net>
In-Reply-To: <1265396794.24463.321.camel@rendellf>
References: <1265396794.24463.321.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Feb 2010 12:06:34 -0700 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> linux-compile.onstor.net $ p4 describe 34394
> Change 34394 by rendellf@rendellf-test on 2010/02/05 09:35:42
> *pending*
> 
>    Updated sb1250 driver based on a more recent release and other net
>    drivers to support access of rmon hardware stats.  Also added
> support to operate with ethtool.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#3
> edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-
> stats/stats-sbmac.h#1 add


= Change 34394 by rendellf@rendellf-test on 2010/02/05 09:35:42 *pending*
= 
= 	Updated sb1250 driver based on a more recent release and other net
= 	drivers to support access of rmon hardware stats.  Also added support
= 	to operate with ethtool.
= 

a) why are we doing this?
b) how/why/where did these come from?
c) did you pull these changes in using git, and if not, then why not?
d) where is the git changes?
e) why can't we wait until we go to 2.6.31/2 to do this, making life a lot easier?

