AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E06B700@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 5 Feb 2010 12:02:32 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34406
Message-ID: <20100205120232.11a1df01@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E06B700@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06B700@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Feb 2010 12:26:32 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34406 by maximk@maximk-5 on 2010/02/05 11:23:47 *pending*
> 
>         Add module exports.
>                Make swapfile_init() module init function instead of
> calling it directly from fs-api.c.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-api.c#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-swapfile/swapfile-api.h#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-swapfile/swapfile.c#4 edit

= Change 34406 by maximk@maximk-5 on 2010/02/05 11:23:47 *pending*
= 
= 	Add module exports.
= 	       Make swapfile_init() module init function instead of calling 
= 	       it directly from fs-api.c.
= 	       Reviewed by andys.
= 


This huge number of modules will require a huge number of symbol exports,
which are fairly expensive memory wise.  Just one of the reasons I
decided not to go that way on the txrx code.

Additionally, and maybe it won't be a problem on the FP side of things,
but there really is no way to come up with a module load order that will
work with the txrx code, as everything is dependent on everything.

Just something to think about.  I don't want you to spend a lot of effort
on something that you may have to then go back and rip out.

That said, these changes are ok.


nfx-tree/code/sm-fs/fs-api.c

     looks good

nfx-tree/code/sm-swapfile/swapfile-api.h

     looks good

nfx-tree/code/sm-swapfile/swapfile.c

     looks good

