AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1265408021.24463.351.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 5 Feb 2010 14:48:17 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 34408
Message-ID: <20100205144817.4e0b7aca@ripper.onstor.net>
In-Reply-To: <1265408021.24463.351.camel@rendellf>
References: <1265398569.24463.325.camel@rendellf>
	<20100205115430.42a9fd41@ripper.onstor.net>
	<1265400780.24463.332.camel@rendellf>
	<20100205135953.1d52d96c@ripper.onstor.net>
	<1265408021.24463.351.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Feb 2010 15:13:41 -0700 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> On Fri, 2010-02-05 at 14:59 -0700, Andrew Sharp wrote:
> > On Fri, 5 Feb 2010 13:13:00 -0700 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > On Fri, 2010-02-05 at 12:54 -0700, Andrew Sharp wrote:
> > > > On Fri, 5 Feb 2010 12:36:09 -0700 Rendell Fong
> > > > <Rendell.Fong@lsi.com> wrote:
> > > > 
> > > > > Change 34408 by rendellf@rendellf-test on 2010/02/05 11:30:33
> > > > > *pending*
> > > > > 
> > > > >    Changed default bonding driver configuration to create 2
> > > > > devices and use 802.3AD mode.
> > > > > 
> > > > > Affected files ...
> > > > > 
> > > > > tuxrx/linux/kernel/linux-mips-2.6/drivers/net/bonding/bond_main.c#1
> > > > > tuxrx/linux/kernel/linux-mips-2.6/include/linux/if_bonding.h#1
> > > > 
> > > > 
> > > > 
> > > > = Change 34408 by rendellf@rendellf-test on 2010/02/05 11:30:33
> > > > *pending* = 
> > > > = 	Changed default bonding driver configuration to
> > > > create 2 devices and use = 	802.3AD mode.
> > > > = 
> > > > 
> > > > 
> > > > We can't change kernel code like this just to make it
> > > > convenient. Then we have to maintain those changes throughout
> > > > history.
> > > > 
> > > > Just use the facilities available to modify these parameters,
> > > > either module parameters or /sys or what have you.
> > > > 
> > > > Let me know if you have questions.
> > > > linux/kernel/linux-mips-2.6/drivers/net/bonding/bond_main.c
> > > > 
> > > >      no
> > > 
> > > changing the mode is something that is being checked for.
> > > so I can get by w/o this.
> > > 
> > > > 
> > > > linux/kernel/linux-mips-2.6/include/linux/if_bonding.h
> > > > 
> > > >      no
> > > > 
> > > 
> > > ok, tell me how to create 2 devices.
> > 
> > Hey, that's why we pay you the mega-puny bucks!  To figure this
> > stuff out.  Maybe you have to have ifenslave after all, if you
> > can't do it through module parameters (which work regardless of
> > whether it's a module or not) or through /sys.
> > 
> > Besides, we only need one right now, yes? ~:^)
> > 
> 
> ok, I figured it out.  We do need 2 when all 4 ports are used in 2
> groups of 2.

Give that man a raise!

What?  We're out of money?  Oh, sorry, you're screwed.
