AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E06B42F@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 8 Feb 2010 11:23:42 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34372
Message-ID: <20100208112342.61c31832@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E06B42F@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06B42F@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 4 Feb 2010 14:56:27 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> From: Kozlovsky, Maxim
> Sent: Wednesday, February 03, 2010 3:01 PM
> To: Sharp, Andy
> Subject: Please review .7
> 
> Change 34372 by maximk@maximk-5 on 2010/02/03 15:00:20 *pending*
> 
>         Fix sm-file compilation, replace printf with printk, fix
> printf format move the variable definitions.
>                 Extract file-lib portion into a separate module.
>                Mark unresolved code instead of just commenting it out.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/Makefile.acpu#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-file/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-file/file-buf-api.c#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-file/file-lib.c#8 edit
> ... //depot/tuxrx/nfx-tree/code/sm-file/file-seccache-api.c#2 edit
> 


= Change 34372 by maximk@maximk-5 on 2010/02/03 15:00:20 *pending*
= 
= 	Fix sm-file compilation, replace printf with printk, fix printf
= 	       format move the variable definitions.
= 	        Extract file-lib portion into a separate module.
= 	       Mark unresolved code instead of just commenting it out.
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-file/Makefile

     looks good

     this is an example of a piece of code that was compiled twice in
     the old method, once for txrx and once for fp.  that means we
     need to figure out what we're going to do with it for tuxstor.
     compile it just once, but refactor it so that makes sense, or ?
     i believe make also goes into sm-file for the userland build.
     it looks like you have the user/kernel part handled, but i forgot
     to look at the makefile regarding NFP_TXRX and NFP_FP

nfx-tree/code/sm-file/file-buf-api.c

     looks good

nfx-tree/code/sm-file/file-lib.c

     looks good

nfx-tree/code/sm-file/file-seccache-api.c

     looks good

