AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E06B430@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 8 Feb 2010 12:22:34 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34317
Message-ID: <20100208122234.5ff414d5@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E06B430@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06B430@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 4 Feb 2010 14:56:43 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> From: Kozlovsky, Maxim
> Sent: Wednesday, February 03, 2010 10:06 AM
> To: Sharp, Andy
> Subject: Please review .2
> 
> Change 34317 by maximk@maximk-5 on 2010/01/29 14:47:14 *pending*
> 
>         Fix sm-ndmp compilation
>                Change logging format
>                Replace printf with printk, bcopy with memcpy,
> ATOMIC_XXX with atomic_xxx
>                Move variable definitions.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/Makefile#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-comm-util.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-data-func.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-debug.h#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-fp.h#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-mover-func.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-msg-tbl.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-msg.c#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-nim-cmd.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-nim-util.c#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp-test.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp_xdr.h#2 edit
> 



= Change 34317 by maximk@maximk-5 on 2010/01/29 14:47:14 *pending*
= 
= 	Fix sm-ndmp compilation
= 	       Change logging format
= 	       Replace printf with printk, bcopy with memcpy, ATOMIC_XXX with 
= 	       atomic_xxx
= 	       Move variable definitions.
= 	       Reviewed by andys.
= 

nfx-tree/Makefile.tuxstor

     lines 22-26 it was so even and pretty before



nfx-tree/code/sm-ndmp/Makefile

     looks good

nfx-tree/code/sm-ndmp/ndmp-comm-util.c

     looks good

nfx-tree/code/sm-ndmp/ndmp-data-func.c

     looks good

nfx-tree/code/sm-ndmp/ndmp-debug.h

     looks good

nfx-tree/code/sm-ndmp/ndmp-fp.h

     line 91+  dang, all the backslashes used to line up...

     line 98, didn't you change this to not have the extra parens?

     line 98,106 use the read method rather than .counter

nfx-tree/code/sm-ndmp/ndmp-mover-func.c

     line 21 this is a case where it won't find this header file,
     because it has "../" in the path

     line 3557  i guess you didn't change NDMP_DBG_PRINTF one to be
     a variable macro.  maybe it would be a good idea?


nfx-tree/code/sm-ndmp/ndmp-msg-tbl.c

     looks good

nfx-tree/code/sm-ndmp/ndmp-msg.c

     looks good

nfx-tree/code/sm-ndmp/ndmp-nim-cmd.c

     line 333 change these to read method; there's some below as well
     in printk's

nfx-tree/code/sm-ndmp/ndmp-nim-util.c

     looks good

nfx-tree/code/sm-ndmp/ndmp-test.c

     looks good

nfx-tree/code/ssc-ndmp/ndmp_xdr.h

     looks good

