AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E06BCB3@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 8 Feb 2010 14:55:42 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34440
Message-ID: <20100208145542.4f6fe713@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E06BCB3@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06BB9B@cosmail02.lsi.com>
	<20100208144930.6f85d2b4@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E06BCB3@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

ok

On Mon, 8 Feb 2010 15:50:22 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> It is in a different change. I'll check in just deletion of sm-event
> in this change.
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Monday, February 08, 2010 2:50 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34440
> 
> On Mon, 8 Feb 2010 12:40:26 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 34440 by maximk@maximk-5 on 2010/02/08 11:38:42 *pending*
> > 
> >         Make sm-event a module, fix printf/printk, add module
> > exports. Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/nfx-tree/code/Makefile.acpu#6 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-event/Makefile#1 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-event/event-mgr.c#4 edit
> > 
> 
> 
> 
> = Change 34440 by maximk@maximk-5 on 2010/02/08 11:38:42 *pending*
> = 
> = 	Make sm-event a module, fix printf/printk, add module
> exports. = 	       Reviewed by andys.
> = 
> 
> 
> No mention of the deletion of the icu stuff, which seems to be
> strange, since we need it.
> 
> 
> 
> nfx-tree/code/Makefile.acpu
> 
> 
>      hmm, the icu stuff needs to be in here, where's it going?
> 
> 
> 
> nfx-tree/code/sm-event/Makefile
> 
> 
>      looks good
> 
> 
> nfx-tree/code/sm-event/event-mgr.c
> 
> 
>      looks good
> 
> 
