AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	13767	861DA0537719934884B3D30A2666FECC010E06B6D6@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 8 Feb 2010 15:20:24 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34401
Message-ID: <20100208152024.7a2367a1@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E06B6D6@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06B6D6@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Feb 2010 11:52:15 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34401 by maximk@maximk-5 on 2010/02/05 10:51:26 *pending*
> 
>                 Add known undefined symbols to linux-stubs to get
> them out of the way and make clear what needs to be fixed.
>                        Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/smoo-linux/Makefile#1 add
> ... //depot/tuxrx/nfx-tree/code/smoo-linux/linux-stubs.c#2 edit



= Change 34401 by maximk@maximk-5 on 2010/02/05 10:51:26 *pending*
= 
= 	Add known undefined symbols to linux-stubs to get them out of the way
= 	       and make clear what needs to be fixed.
= 	       Reviewed by andys.
= 

nfx-tree/code/smoo-linux/Makefile

     >>add nfx-tree/code/smoo-linux/Makefile

     Why have a makefile here?  I think you have module-itus.  The
     header file should be enough, plus correct module loading order.

nfx-tree/code/smoo-linux/linux-stubs.c

     line 5 let's not make every last line of code a separate module

     as for the added stuff, that's basically ok

     line 150 i thought Rendell already has added this somewhere

     line 152 i definitely added this some where.  although there's
     always the chance i forgot to check it in, or Bill removed it
     by not taking the changes into his version of some file....now
     i think i know why agami never shipped anything.

