AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<jan.seidel@lsi.com>,<Jobi.Ariyamannil@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILxEfhzL1f6Ykw0011fcc8@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 9 Feb 2010 14:00:30 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Jan Seidel <jan.seidel@lsi.com>
Cc: Jobi Ariyamannil <Jobi.Ariyamannil@lsi.com>
Subject: Re: PERFORCE change 34486 for review
Message-ID: <20100209140030.2057c199@ripper.onstor.net>
In-Reply-To: <WEBMAILxEfhzL1f6Ykw0011fcc8@mail.onstor.com>
References: <WEBMAILxEfhzL1f6Ykw0011fcc8@mail.onstor.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 9 Feb 2010 12:25:01 -0700 Jan Seidel <jan.seidel@lsi.com> wrote:

> Change 34486 by jans@jans-devwork on 2010/02/09 11:23:44
> 
> 	Workaround for bug in tuxfs branch: A vsvr disable / enable
> fails for a vsvr which has volumes configured. 
> 	In the setup_config of tests now disable / enable the vsvr
> before adding volumes to it. 
> 	Reviewed by JobiA.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/test/lib/ONStor/Expect/GW/Nfxsh/Testutils.pm#25
> edit
> 
> 
> http://liszt.onstor.net:1818/@md=d&cd=//depot/$c=G35@/34486?ac=10

Uh, maybe I missed something here, but tests should not work around
bugs in the code!  They should exacerbate them.  Maybe we should add
tests that enable/disable vsvr's before adding volumes, but the
original tests should remain, especially since they apparently
already found a bug!

