AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Jan.Seidel@lsi.com>,<Jobi.Ariyamannil@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	D41A5B864986B546A595D85C4701A9C0B6FF3654@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 9 Feb 2010 16:16:09 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Seidel, Jan" <Jan.Seidel@lsi.com>
Cc: "Ariyamannil, Jobi" <Jobi.Ariyamannil@lsi.com>
Subject: Re: PERFORCE change 34486 for review
Message-ID: <20100209161609.54846572@ripper.onstor.net>
In-Reply-To: <D41A5B864986B546A595D85C4701A9C0B6FF3654@cosmail03.lsi.com>
References: <WEBMAILxEfhzL1f6Ykw0011fcc8@mail.onstor.com>
	<20100209140030.2057c199@ripper.onstor.net>
	<5D3F3304755C724285AA5789BA159920BADB0181@cosmail03.lsi.com>
	<D41A5B864986B546A595D85C4701A9C0B6FF3654@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Oh good.  I hate to see successful tests throw away!  ~:^)

On Tue, 9 Feb 2010 16:32:52 -0700 "Seidel, Jan" <Jan.Seidel@lsi.com>
wrote:

> Hi Andy,
> 
> I should have made that clearer in the original submittal note. Jobi
> is right, in this case we hit this bug as a side-effect of the setup
> test. We have special vsvr disable / enable tests and we'll also add
> additional tests.
> 
> -----Original Message-----
> From: Ariyamannil, Jobi 
> Sent: Tuesday, February 09, 2010 2:25 PM
> To: Sharp, Andy; Seidel, Jan
> Subject: RE: PERFORCE change 34486 for review
> 
> We do have tests for testing vsvr disable/enable with volumes mounted.
> 
> There is no need to do things in an inefficient manner when general
> tests are started. The code change made is a good thing to make
> anyway irrespective of the bug uncovered.
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Tuesday, February 09, 2010 2:01 PM
> To: Seidel, Jan
> Cc: Ariyamannil, Jobi
> Subject: Re: PERFORCE change 34486 for review
> 
> On Tue, 9 Feb 2010 12:25:01 -0700 Jan Seidel <jan.seidel@lsi.com>
> wrote:
> 
> > Change 34486 by jans@jans-devwork on 2010/02/09 11:23:44
> > 
> > 	Workaround for bug in tuxfs branch: A vsvr disable / enable
> > fails for a vsvr which has volumes configured. 
> > 	In the setup_config of tests now disable / enable the vsvr
> > before adding volumes to it. 
> > 	Reviewed by JobiA.
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/test/lib/ONStor/Expect/GW/Nfxsh/Testutils.pm#25
> > edit
> > 
> > 
> > http://liszt.onstor.net:1818/@md=d&cd=//depot/$c=G35@/34486?ac=10
> 
> Uh, maybe I missed something here, but tests should not work around
> bugs in the code!  They should exacerbate them.  Maybe we should add
> tests that enable/disable vsvr's before adding volumes, but the
> original tests should remain, especially since they apparently
> already found a bug!
> 
