AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E0E5D71@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 9 Feb 2010 17:29:16 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34489
Message-ID: <20100209172916.783eb79c@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E0E5D71@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06BF63@cosmail02.lsi.com>
	<20100209171752.646ffc4a@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E5D71@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

ok

On Tue, 9 Feb 2010 18:21:57 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Tuesday, February 09, 2010 5:18 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34489
> 
> On Tue, 9 Feb 2010 12:48:20 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 34489 by maximk@maximk-5 on 2010/02/09 11:47:29 *pending*
> > 
> >         FS_USE_MALLOC_SLAB needs to be defined.
> >                Replace cache_alloc/cache_free with
> > kmem_cache_alloc/free. Doing cleanup_caches() directly is not going
> > to be supported. Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#9 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-admin.c#5 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-context.c#5 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-context.h#3 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-debug.c#6 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-global.c#5 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-global.h#5 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-proto.h#5 edit
> > 
> 
> 
> 
> = Change 34489 by maximk@maximk-5 on 2010/02/09 11:47:29 *pending*
> = 
> = 	FS_USE_MALLOC_SLAB needs to be defined.
> = 	       Replace cache_alloc/cache_free with
> kmem_cache_alloc/free. = 	       Doing cleanup_caches()
> directly is not going to be supported. = 	       Reviewed by
> andys. = 
> 
> 
> 
> nfx-tree/Makefile.tuxstor
> 
>      rather than adding a superfluous flag, why don't we just rip out
>      the #ifdefs?
> [MK] Yeah, yeah, we could. Takes longer though.
> 
> nfx-tree/code/sm-fs/fs-admin.c
> 
>      like you did here?
> [MK] I reversed the #ifdef, it was peeking into the memory manager
> structures directly I changed it to call the function which is
> currently on the todo list in linux-stubs.c
> 
> nfx-tree/code/sm-fs/fs-context.c
> 
>      line 2585 <code deleted> this doesn't appear to be related to
>      the checkin comment?
> 
> [MK] It is related, deletes call to cleanup caches.
> 
> nfx-tree/code/sm-fs/fs-context.h
> 
>      looks good
> 
> nfx-tree/code/sm-fs/fs-debug.c
> 
>      looks good
> 
> nfx-tree/code/sm-fs/fs-global.c
> 
>      looks good
> 
> nfx-tree/code/sm-fs/fs-global.h
> 
>      looks good
> 
> nfx-tree/code/sm-fs/fs-proto.h
> 
>      looks good
> 
