AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E0E5D76@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Feb 2010 09:45:19 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34474
Message-ID: <20100210094519.57532811@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E0E5D76@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06BD6B@cosmail02.lsi.com>
	<20100209171318.04912561@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E5D76@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 9 Feb 2010 18:31:38 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Please rereview, they actually do malloc the memory for the name
> buffer inside the file-server code... 
> 
> 
> Change 34474 by maximk@maximk-5 on 2010/02/08 17:50:03 *pending*
> 
>                Remove the references to mm_isMallocBuffer(). 
>                Add a flag telling whether the name was malloced in
> file-server code, instead of relying on mm_isMallocBuffer().
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-file/file-api.h#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-file/file-server.c#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-icu-common/unicode/icu_wrappers.h#4
> edit
> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Tuesday, February 09, 2010 5:13 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34474
> 
> On Mon, 8 Feb 2010 18:50:40 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 34474 by maximk@maximk-5 on 2010/02/08 17:50:03 *pending*
> > 
> >                Remove the references to mm_isMallocBuffer().
> >                Remove the code freeing the name from
> > file_req_create(), it is not necessary as all existing callers are
> > using eee descriptor they free themselves.
> >                Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/nfx-tree/code/sm-file/file-server.c#6 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/unicode/icu_wrappers.h#4
> > edit
> > 
> 
> 
> looks good




= Change 34474 by maximk@maximk-5 on 2010/02/08 17:50:03 *pending*
= 
= 	       Remove the references to mm_isMallocBuffer(). 
= 	       Add a flag telling whether the name was malloced in file-server code, 
= 	       instead of relying on mm_isMallocBuffer().
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-file/file-api.h

     looks good

nfx-tree/code/sm-file/file-server.c

     line 4354 is  FILE_O_FROM_NAME_EDESC and  FILE_O_TARGET_NAME_EDESC
     deprecated now?  if so, perhaps you should remove their definitions
     to be safe - find all uses.



nfx-tree/code/sm-icu-common/unicode/icu_wrappers.h

     looks good

