AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E0E5F22@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Feb 2010 11:24:11 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34474
Message-ID: <20100210112411.7a799875@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E0E5F22@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E06BD6B@cosmail02.lsi.com>
	<20100209171318.04912561@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E5D76@cosmail02.lsi.com>
	<20100210094519.57532811@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E5F22@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 10 Feb 2010 11:41:38 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> nfx-tree/code/sm-file/file-api.h
> 
>      looks good
> 
> nfx-tree/code/sm-file/file-server.c
> 
>      line 4354 is  FILE_O_FROM_NAME_EDESC and
> FILE_O_TARGET_NAME_EDESC deprecated now?  if so, perhaps you should
> remove their definitions to be safe - find all uses.
> 
> 
> [MK] They are not deprecated. The callers use FILE_O_FROM_NAME_EDESC
> nad FILE_O_TARGET_NAME_EDESC to pass the file name in a eee
> descriptor, that they retain the ownership of. The file-server code
> allocates a buffer with eee_ramAlloc() and replaces the pointer to
> the descriptor with the pointer to the buffer, which is owned by the
> file-server code and needs to be freed there as well. They used the
> mm_isMallocBuffer() hack to distinguish between the case where the
> conversion to the flat buffer has happened from the case where the
> error happened before that point in the processing. The new flags
> make this explicit.

got it.  mostly ~:^)