AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1265827136.16781.19.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Feb 2010 11:26:33 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: PERFORCE change 34511 for review
Message-ID: <20100210112633.2fb5c395@ripper.onstor.net>
In-Reply-To: <1265827136.16781.19.camel@rendellf>
References: <WEBMAILnsNTM7pFLpEo001205e7@mail.onstor.com>
	<20100210102103.264a7685@ripper.onstor.net>
	<1265827136.16781.19.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 10 Feb 2010 11:38:56 -0700 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> 
> 
> On Wed, 2010-02-10 at 11:21 -0700, Andrew Sharp wrote:
> > On Tue, 9 Feb 2010 18:30:02 -0700 Rendell Fong
> > <rendell.fong@lsi.com> wrote:
> > 
> > > Change 34511 by rendellf@rendellf-test on 2010/02/09 17:28:22
> > > 
> > > 	Removed vstack APIs that are obsolete for tuxstor.
> > > 	Updated net interface stat counter types.
> > > 	Reviewed by: MaximK
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-net/vstack_link.h#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-net/vstack_vlink.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-netinet/vstack.h#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-netinet/vstack_if.h#3 edit
> > 
> > these directories are going away, so if there's some cruft in them
> > that we aren't throwing away, then it needs to be moved to
> > somewhere that isn't going down the drain.
> 
> If you feel like renaming the files and moving them, then have at it.
> Just remember that you'll have to change all refs as well.

Hey.  That's my line.


> > 
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsEthernet.c#4
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/mibII/interfaces.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_arp.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_port.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_vif.c#4 edit
> > 
> > you did 't make changes to the UI, did you?
> > 
> 
> Stat counters have changed.

In what way?  We can't break the GUI.
