AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E0E5FA0@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Feb 2010 13:59:01 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34533
Message-ID: <20100210135901.38769ea3@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E0E5FA0@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E0E5FA0@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 10 Feb 2010 13:08:06 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34533 by maximk@maximk-5 on 2010/02/10 12:07:34 *pending*
> 
>         Move the code to get the mac addr to ispfc to resolve
>                seep_getMyExtMacAddr() reference.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#3
> edit ... //depot/tuxrx/nfx-tree/code/sm-ispfc/ispfc_nvram.c#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-seep/seep-api.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-seep/seep-api.h#2 edit
> 



= Change 34533 by maximk@maximk-5 on 2010/02/10 12:07:34 *pending*
= 
= 	Move the code to get the mac addr to ispfc to resolve   
= 	       seep_getMyExtMacAddr() reference.
= 	       Reviewed by andys.
= 

linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c

     looks good

nfx-tree/code/sm-ispfc/ispfc_nvram.c

     line 26 please use angle brackets ala line 22

     line 27 that's a no-no.  please do it right.  i'm pretty sure it
     won't find it anyway with that path.  ideally you can figure a way
     not to have to move this header file, like, don't use it at all.

     line 56 seepInitExtMacAddr  I don't know what you're trying to do
     here.  This appears to be the mac addr for the FP ports.  Is that
     related to ispfc somehow?  if so, we can get this accomplished by
     sharing it from the ethernet driver, which already does this hack.
     probably not as cleanly, since i wrote it in about 4 seconds a
     year ago....

nfx-tree/code/sm-seep/seep-api.c

     looks good

nfx-tree/code/sm-seep/seep-api.h

     looks good

