AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E0E6052@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Feb 2010 14:51:23 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34533
Message-ID: <20100210145123.7f0015cd@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E0E6052@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E0E5FA0@cosmail02.lsi.com>
	<20100210135901.38769ea3@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E602A@cosmail02.lsi.com>
	<20100210142523.6c0f532f@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E6052@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 10 Feb 2010 15:39:56 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> > 
> >      line 27 that's a no-no.  please do it right.  i'm pretty sure
> > it won't find it anyway with that path.  ideally you can figure a
> > way not to have to move this header file, like, don't use it at all.
> > [MK] Of course it will find it. Linux/kernel/linux/include is in the
> > path so ../drivers resolves to what it needs to resolve to. Why
> > bother and what exactly is wrong with including the file I need to
> > include?
> 
> It's not allowed to arbitrarily include files from around the
> kernel tree.  If you want to include a file in multiple sections, it
> needs to be located in the include directory.  It can be in the
> include/onstor directory if you like.  Or just do without it.
> [MK] 
> Ok moved the file
> 
> >      line 56 seepInitExtMacAddr  I don't know what you're trying to
> > do here.  This appears to be the mac addr for the FP ports.  Is that
> >      related to ispfc somehow?  if so, we can get this accomplished
> > by sharing it from the ethernet driver, which already does this
> > hack. probably not as cleanly, since i wrote it in about 4 seconds a
> >      year ago....
> > [MK] The FC ports also have some notion of MAC address that they
> > derive from the host id, they call it WWN. This code already works,
> > why fix it.
> 
> You got me wrong, I'm not saying it needs fixing, just reconciling
> with the code that already does this in the nic driver.  It needed to
> be duplicated back when txrx and fp were different images, but not
> now. [MK] I am not taking that code, it is too ugly. Using some weird
> constants all over the place. Let's not spent too much time over
> almost dead code?

ok, whatever.  yes, it's hideous code, i fully admit it.  perhaps
there's a way to throw it away and depend on this code in ispfs?  ah,
one hack traded for another.  nm.

> 	magicmanagementbusringconfig = (char *)ioremap(0x1000000000ULL
> 			| PCI_SHARED_MEM_OFF, 0x100);
> 	for (idx = 0; idx < chip_max_units; idx++) {
> 		char ons_mac_str[] = "00:07:34:00:00:00";
> 
> 		sprintf(&ons_mac_str[9], "%02X:%02X:%02X",
> 				*(magicmanagementbusringconfig + 230),
> 				*(magicmanagementbusringconfig + 229),
> 				*(magicmanagementbusringconfig + 228)
> | (0x10 | idx));
> 
> > nfx-tree/code/sm-seep/seep-api.c
> > 
> >      looks good
> > 
> > nfx-tree/code/sm-seep/seep-api.h
> > 
> >      looks good
> > 
