AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E0E6065@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Feb 2010 14:57:41 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34532
Message-ID: <20100210145741.65f7d697@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E0E6065@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E0E5F85@cosmail02.lsi.com>
	<20100210134637.4c098e28@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E6011@cosmail02.lsi.com>
	<20100210142043.27d70b37@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E6048@cosmail02.lsi.com>
	<20100210145355.2e93fbf3@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E0E6065@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 10 Feb 2010 15:55:03 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> > No, this has already been done somewhere else.  I seem to recall I
> > had a hand in doing it, but it was something like 6 months ago.
> > [MK] 
> > You probably talking about this code in author_getStackTrace()
> > 
> > 	struct stack_trace __st;                         \
> > 	__st.max_entries = _num_frames;                  \
> > 	__st.entries = (unsigned long *)_ra_array;       \
> > 	save_stack_trace(&__st)
> > 
> > It was using do_stack_trace() before but you and Rendell changed
> > just this spot only to use linux code instead of fixing everything
> > at once. The other places still need to be fixed.
> 
> I suspect it was the only place known at the time.  I don't
> specifically recall that function.
> 
> Feel free to convert author_getST to something better if you like ~:^)
> [MK] 
> OK may be I will. Can I check in this code now so this can be dealt
> with later? 

Yes, that's what I meant.
