AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E178369@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 18 Feb 2010 14:50:11 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34632
Message-ID: <20100218145011.74027130@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E178369@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E1782B9@cosmail02.lsi.com>
	<20100218140630.6545caf9@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E17835B@cosmail02.lsi.com>
	<20100218141309.1076b5e1@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E178369@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 18 Feb 2010 15:16:52 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Thursday, February 18, 2010 2:13 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34632
> 
> On Thu, 18 Feb 2010 15:07:59 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > 
> > 
> > = Change 34632 by maximk@maximk-5 on 2010/02/18 11:55:52 *pending*
> > = 
> > = 	Bring eee_rtcZero() definition in neteee2 in sync with 
> > = 	       nfx-tree/code/neteee2.
> > = 	       Reviewed by andys.
> > = 
> > 
> > linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/eee-timer-api.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api.c
> > 
> >      i'm not sure i understand, i thought I changed this silliness.
> >      i changed rtcZero to be just a macro that evaluates to {0}
> >      because all callers of rtcZero just say foo=*rtcZero() and it's
> >      just very silly that we have a static variable and all this
> >      stuff just to zero out a simple structure.  and i changed all
> >      the callers to be foo=rtcZero() or something like that, which
> > is much more understandable anyway.  and, it's a crap load faster.
> >      Did that code get lost?
> > 
> > [MK] You did not change all the callers. There are still plenty,
> > grep the tree.
> 
> I changed all the callers that were compiling at the time, which only
> included the txrx code, of course.  It was last summer for crying out
> loud.
> [MK] Well we still have them in the code that is compiling now. If
> you would like to change it, go ahead, I'd rather define a two line
> function and move on.

sigh, yes go ahead
