AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E17844C@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 19 Feb 2010 10:01:05 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34619
Message-ID: <20100219100105.760b86af@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E17844C@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E178420@cosmail02.lsi.com>
	<20100218174036.50a53b3b@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E17844C@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 18 Feb 2010 19:46:32 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Thursday, February 18, 2010 5:41 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34619
> 
> On Thu, 18 Feb 2010 18:17:15 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > This is still pending from yesterday.
> > 
> > From: Kozlovsky, Maxim
> > Sent: Wednesday, February 17, 2010 4:22 PM
> > To: Sharp, Andy
> > Subject: Please review 34619
> > 
> > Change 34619 by maximk@maximk-5 on 2010/02/17 16:20:16 *pending*
> > 
> >         fix cache_create() definition, size and slabsize were
> > reversed. Don't pass slab debug flags unless CONFIG_DEBUG_SLAB is
> > defined, this causes kernel panic.
> >                Call kmem_cache_create directly in esm init.
> >                Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/nfx-tree/Includes/linux/typalooza.h#2 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.c#4 edit
> 
> 
> = Change 34619 by maximk@maximk-5 on 2010/02/17 16:20:16 *pending*
> = 
> = 	       fix cache_create() definition, size and slabsize
> were reversed. = 	              Don't pass slab debug flags
> unless CONFIG_DEBUG_SLAB is defined, = 	              this
> causes kernel panic. = 	              Call kmem_cache_create
> directly in esm init. = 	              Reviewed by andys.
> = 
> 
> 
> It seems we want the kernel panic!  If CONFIG_SLAB_DEBUG turns on all
> those flags for all caches, then fine, they don't need to be in the
> macro.
> [MK] Not this panic. CONFiG_SLAB_DEBUG turns on all the debug flags
> anyway, if CONFIG_SLAB_DEBUG is not defined and debug flags are
> passed, kmem_cache_create() causes assertion. Everybody in the kernel
> just passes 0 for flags almost everywhere.

ok

> 
> nfx-tree/Includes/linux/typalooza.h
> 
>      line 39 this should have been 'isize' instead of 'size'; that's
>      all that needs changing.  nothing on line 38 needs to be changed.
>      i don't see why you would want to remove the flags while we're
>      in this stage.
> [MK] ok for isize, see above for flags.

yup

> nfx-tree/code/sm-esm/esm.c
> 
>      line 266 why not use cache_create() macro?  then flag changes
>      and everything else will follow the macro....i'm just saying
> [MK] the macro has two unused arguments and does not allow passing
> the cache name. we really want to pass 0 for flags in (almost) all
> cases. 

I don't want to give the impression that I care very much, but yes, it
passes the cache name.  But since we aren't going to use the flags,
there's no point in using the macro except for porting convenience.

So fire this baby in there.


