AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E178D8C@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 23 Feb 2010 11:54:07 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review
Message-ID: <20100223115407.0d1029c8@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E178D8C@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E178D8C@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 23 Feb 2010 11:41:53 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34672 by maximk@maximk-13 on 2010/02/23 10:40:54 *pending*
> 
>         Create FP polling threads in eee init function.
>                Add sleep/wakeup mechanism to polling loop, the
> polling thread will go to sleep if the loop did not process any
> events. Add module exit function.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#8
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c#7
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c#5
> edit
> 



= Change 34672 by maximk@maximk-13 on 2010/02/23 10:40:54 *pending*
= 
= 	Create FP polling threads in eee init function.
= 	       Add sleep/wakeup mechanism to polling loop, the polling thread
= 	       will go to sleep if the loop did not process any events.
= 	       Add module exit function.
= 	       Reviewed by andys.
= 


My biggest concern is that there are design changes represented by some of
this code.  Not big changes necessarily, but ones which a wider audience
should know about?  I'm specifically thinking about Bill.


linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c

     looks good

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h

     line 47 bool?  in the kernel?  it's a violation against man
     and nature.  I prefer to stick to non-imaginary data types in the
     kernel as much as possible.  More about this farther down.


linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h

     ok


linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c

     line 94 why test eee.eee_threads[i] for NULL?  If it can be NULL,
     then possibly this is racy and should be protected by a lock?

     line 208 just curious, what module is this?

linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c

     line 371 nice, except for the bool, which i know you will fix ~:^)

     line 439 seriously, why do we need two?  sed
     s/eee_registerPollingFunc/eee_register_polling_func/

     line 691 the userspace 'bool' type.  since you're
     doing integer operations on it, let's make it an unsigned int LGI.

     line 717 this looks like a good candidate for an inline

     line 737 sheesh, about time someone who knows how to write kernel
     code got involved.  nice.  on orion, the I/O VM has a problem
     right now: it uses 100% cpu all the time.  maybe we should loan
     you to them.  naaah.  ~:^)


