AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755EB50C457@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 23 Feb 2010 16:28:55 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: please review change 34652 -- add our header files to the
 header_install rule
Message-ID: <20100223162855.4621c4ff@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755EB50C457@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755EB50C444@cosmail02.lsi.com>
	<20100222141257.7a281a54@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755EB50C457@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Something is all goofed up in this reply, possibly some of my comments
or other lines got deleted....

Anyway, my bad, req-tbl.h is the generated file.

I guess the only other thing is, what does the part of the comment
inside the parens mean?


On Tue, 23 Feb 2010 16:24:14 -0700 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> The first thing I tried was just using the top level Kbuild file
> only. That didn't work. The next was trying just the onstor/Kbuild
> file that didn't work completely, either. Looks like each
> subdirectory needs its own Kbuild file in order to work with make
> headers_install.
> 
> All the header files in linux-mips-2.6/include/linux/onstor/ are
> checked into the depot. The file
> linux/onstor/sm-req-queue/req-queue-struct.h is not a generated file.
> It was integrated from code/req-queue-struct.h  
> 
> It should have been integrated from code/sm-req-queue but doesn't
> appear to have been.
> 
> Larry
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Monday, February 22, 2010 2:12 PM
> To: Scheer, Larry
> Subject: Re: please review change 34652 -- add our header files to
> the header_install rule
> 
> On Fri, 19 Feb 2010 17:28:46 -0700 "Scheer, Larry"
> <Larry.Scheer@lsi.com> wrote:
> 
> > Andy,
> >     This change adds all of our header files in include/linux/onstor
> > directory to the system header files. Let me know if any should be
> > left out or should have the unifdef-y rule applied to them.
> >
> > Larry
> >
> > Change 34652 by larrys@larrys on 2010/02/19 16:28:02 *pending*
> >
> >         Add onstor header files to the kernel's make headers_install
> > process. Header files are not modified by make (no files listed as
> > part of unifdef-y macro.)
> >
> > Affected files ...
> >
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/Kbuild#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/mgmt-bus/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-cifs/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-req-queue/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-rmc/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/Kbuild#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-tpl/Kbuild#1
> > add
> 
> 
> 
> = Change 34652 by larrys@larrys on 2010/02/19 16:28:02 *pending*
> =
> =       Add onstor header files to the kernel's make headers_install
> process. =       Header files are not modified by make (no files
> listed as part of =       unifdef-y macro.)
> 
> 
> I don't know what the part in parens means, but hey.
> 
> 
> linux/kernel/linux-mips-2.6/include/linux/Kbuild
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/Kbuild
> 
>      >>add linux/kernel/linux-mips-2.6/include/linux/onstor/Kbuild
> 
>         excellent
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/mgmt-bus/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/mgmt-bus/Kbuild
> 
>         if you add the directory in the upper level Kbuild file,
>         will it not add allthe files in that directory so you
>         don't need a separate Kbuild file for the files themselves?
>         i don't know if this is the only file in mgmt-bus or not.
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-cifs/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-cifs/Kbuild
> 
>         ok i guess
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/Kbuild
> 
>         is this all the files in this directory?
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/Kbuild
> 
>         same question
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-req-queue/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-req-queue/Kbuild
> 
>         i'm unclear how this could be checked in, i thought it
>         was a generated file.
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-rmc/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-rmc/Kbuild
> 
>         same question as the others
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/Kbuild
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-tpl/Kbuild
> 
>      >>add
>      linux/kernel/linux-mips-2.6/include/linux/onstor/sm-tpl/Kbuild
> 
