AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755EB50C468@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 25 Feb 2010 17:14:27 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: Please review change 34682 fixes for tuxrx nightly build
 problems
Message-ID: <20100225171427.217c7cd3@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755EB50C468@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755EB50C468@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Feb 2010 20:44:11 -0700 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> Change 34682 by larrys@larrys on 2010/02/24 19:38:31 *pending*
> 
>         Changes to fix nightly build problems.
>         -  Tools/suffix.mk -- Fix for No rule to make genfiles in
> sm-appids onstor.apps gets generated.
>         -  Tools/tool-chain-pkg.mk -- integrate from dev branch to get
>            build performance improvement... set GCC_MAJOR only once.
>         -  Fix for parallel make, generated sources should now be
> created before they are used by the compiler. Using the Kbuild
> macroi: extra-y for code generated from .sm files.
>         Reviewed by:
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/Tools/suffix.mk#2 edit
> ... //depot/tuxrx/nfx-tree/Tools/tool-chain-pkg.mk#3 integrate
> ... //depot/tuxrx/nfx-tree/code/sm-file/Makefile#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-fs/Makefile#8 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ndmp/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-agent/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-sanm-dm/Makefile#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-scsi/Makefile#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-thread/Makefile#3 edit



= Change 34682 by larrys@larrys on 2010/02/24 19:38:31 *pending*
= 
= 	Changes to fix nightly build problems.
= 	-  Tools/suffix.mk -- Fix for No rule to make genfiles in sm-appids
= 	   onstor.apps gets generated.
= 	-  Tools/tool-chain-pkg.mk -- integrate from dev branch to get
= 	   build performance improvement... set GCC_MAJOR only once.
= 	-  Fix for parallel make, generated sources should now be created before
= 	   they are used by the compiler. Using the Kbuild macroi: extra-y for
= 	   code generated from .sm files.
= 	Reviewed by:
= 

nfx-tree/Tools/suffix.mk

     looks good

nfx-tree/Tools/tool-chain-pkg.mk

     looks good

nfx-tree/code/sm-file/Makefile

     looks good

nfx-tree/code/sm-fs/Makefile

     line 99 i think fs-memexer is not generated, but it was missing.
     i believe max put it back in a recent change.  hmm, i don't know,
     though.  maybe it was lines 127-9 that he put back, but I thought
     it was the file.

nfx-tree/code/sm-ndmp/Makefile

     looks good

nfx-tree/code/sm-sanm-agent/Makefile

     looks good

nfx-tree/code/sm-sanm-dm/Makefile

     looks good

nfx-tree/code/sm-scsi/Makefile

     looks good

nfx-tree/code/sm-thread/Makefile

     looks good

