AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E1E8A0B@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 25 Feb 2010 17:57:02 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34696
Message-ID: <20100225175702.71a0b75d@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E1E8A0B@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E1E8A0B@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 25 Feb 2010 15:36:08 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34696 by maximk@maximk-4 on 2010/02/25 14:34:06 *pending*
> 
>                Implement fp timers. Setup a kernel timer to wake the
> polling thread which executes the eee timers in the fp thread context.
>                add acpu_thread to eee config to distinguish between
> callers in fp and acpu contexts down the stack.
>                        add a small test for fp timers.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#4
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/eee-timer.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Makefile#7 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c#8
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c#6
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c#6
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/acpu.c#4
> edit ... //depot/tuxrx/nfx-tree/code/sm-tests/Makefile#1 add
> ... //depot/tuxrx/nfx-tree/code/sm-tests/timer-test.c#1 add
> 



= Change 34696 by maximk@maximk-4 on 2010/02/25 14:34:06 *pending*
= 
= 	       Implement fp timers. Setup a kernel timer to wake the polling
= 	       thread which executes the eee timers in the fp thread context.
= 	       add acpu_thread to eee config to distinguish between callers in
= 	       fp and acpu contexts down the stack.
= 	               add a small test for fp timers.
= 	       Reviewed by andys.
= 

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h

     looks good

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-timer/eee-timer.h

     line 31 my lips are sealed

     line 32 white space violation

     line 39,78 trailing ws



linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c

     line 567 s/run/ran/

     line 577 this looks a bit funky to me.  TAILQ_FIRST will always
     give you the first, but since you release the lock on line 600,
     could it not process the same timer over and over, at least
     in theory?  i assume that's not what you want.

     line 577,8 tws


linux/kernel/linux-mips-2.6/net/onstor/acpu.c

     line 18 or whatever, jesus christo, we have to add 47 header
     files to save the thread id somewhere?  this eee structure seems
     somewhat unnecessary here, can't we just save it in a global?

nfx-tree/code/sm-tests/Makefile

     >>add nfx-tree/code/sm-tests/Makefile ok

nfx-tree/code/sm-tests/timer-test.c

     >>add nfx-tree/code/sm-tests/timer-test.c
     	line 57 tws

     	line 35 shoudn't you return rc here?


