AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E1E8C2B@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 26 Feb 2010 13:28:37 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34696
Message-ID: <20100226132837.399d5d3d@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E1E8C2B@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E1E8A0B@cosmail02.lsi.com>
	<20100225175702.71a0b75d@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E1E8C2B@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 26 Feb 2010 10:53:47 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c
> 
>      line 567 s/run/ran/
> [MK] ok
> 
>      line 577 this looks a bit funky to me.  TAILQ_FIRST will always
>      give you the first, but since you release the lock on line 600,
>      could it not process the same timer over and over, at least
>      in theory?  i assume that's not what you want.
> [MK] The timers are rescheduled with at least 10ms interval, so if
> the same timer happens to be at the head of the list again, it is
> likely it will fail the expiration check. If it passes the expiration
> check, then 10ms has passed and it is right thing to run the timer
> again.

ok, i wondered if that was the case but thought i would ask

>      line 577,8 tws
> [MK] ok
> 
> linux/kernel/linux-mips-2.6/net/onstor/acpu.c
> 
>      line 18 or whatever, jesus christo, we have to add 47 header
>      files to save the thread id somewhere?  this eee structure seems
>      somewhat unnecessary here, can't we just save it in a global?
> [MK] eee seems like a logical place for this variable. We don't want
> to create a separate include file for each variable, do we? I would
> like to add just one header file, but for some reason I could not
> find another way to include that eee.h.

well, how about thread-api.h or esm.h or something like that...
probably already included by the files that would actually need this
value?

> nfx-tree/code/sm-tests/Makefile
> 
>      >>add nfx-tree/code/sm-tests/Makefile ok
> 
> nfx-tree/code/sm-tests/timer-test.c
> 
>      >>add nfx-tree/code/sm-tests/timer-test.c
>      	line 57 tws
> [MK] ok
> 
>      	line 35 shoudn't you return rc here?
> [MK] module initialization function is supposed to return linux error
> codes, rc eee_timerStart() does not return one. I didn't want to
> invent meaningful error codes here, it is just a test, it prints the
> reason for failure to the log in all error paths.

ok

> 
