AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E1E8CCF@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 26 Feb 2010 13:35:44 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34701
Message-ID: <20100226133544.6749f789@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E1E8CCF@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E1E8CCF@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 26 Feb 2010 12:12:02 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34701 by maximk@maximk-2 on 2010/02/26 11:10:42 *pending*
> 
>         Fix make test compilation.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#13 edit
> ... //depot/tuxrx/nfx-tree/Tools/defs.mk#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-anpssc/anpssc-test.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-primitive.h#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-gns/gns-struct.h#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-vscan/vscan.h#3 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-authentication/authen-struct.h#5
> edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-cifs-api.h#3
> edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-gns-api.h#4
> edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-share-api.h#3
> edit ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-nis.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/Makefile#4 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/nfxsh.h#4 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-dbrec.h#3 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-msg.h#6 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-x86-tests/dumpaborttest.c#2 edit


= Change 34701 by maximk@maximk-2 on 2010/02/26 11:10:42 *pending*
= 
= 	Fix make test compilation.
= 	       Reviewed by andys.
= 

nfx-tree/Makefile.tuxstor

     looks good

nfx-tree/Tools/defs.mk

     looks good

nfx-tree/code/sm-anpssc/anpssc-test.c

     looks good

nfx-tree/code/sm-fs/fs-primitive.h

     looks good

nfx-tree/code/sm-gns/gns-struct.h

     looks good

nfx-tree/code/sm-vscan/vscan.h

     looks good

nfx-tree/code/ssc-authentication/authen-struct.h

     looks good

nfx-tree/code/ssc-cluster/cluster-cifs-api.h

     did you also test regular compilation after these changes?

nfx-tree/code/ssc-cluster/cluster-gns-api.h

     looks good

nfx-tree/code/ssc-cluster/cluster-share-api.h

     looks good

nfx-tree/code/ssc-nfxnis/nfxnis-nis.c

     looks good

nfx-tree/code/ssc-nfxsh/Makefile

     line 186,7 Includes/ch?  if we need header files out of there,
     instead move them to somewhere common or non-cheetah related so
     those directories can eventually be deleted.  they should have
     been deleted already.

nfx-tree/code/ssc-nfxsh/nfxsh.h

     looks good

nfx-tree/code/ssc-vsd/vs-dbrec.h

     looks good

nfx-tree/code/ssc-vsd/vs-msg.h

     looks good

nfx-tree/code/ssc-x86-tests/dumpaborttest.c

     looks good

