AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E1E9054@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 1 Mar 2010 10:10:59 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34696
Message-ID: <20100301101059.339a4fc9@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E1E9054@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E1E8A0B@cosmail02.lsi.com>
	<20100225175702.71a0b75d@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E1E8C2B@cosmail02.lsi.com>
	<20100226132837.399d5d3d@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E1E9041@cosmail02.lsi.com>
	<20100301095444.0c4db96a@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E1E9054@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 1 Mar 2010 10:56:46 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Monday, March 01, 2010 9:55 AM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34696
> 
> On Mon, 1 Mar 2010 10:44:17 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Are we done with this change? You did not reply after this.
> > 
> > -----Original Message-----
> > From: Kozlovsky, Maxim 
> > Sent: Friday, February 26, 2010 1:33 PM
> > To: Sharp, Andy
> > Subject: RE: Please review 34696
> > 
> > > 
> > > linux/kernel/linux-mips-2.6/net/onstor/acpu.c
> > > 
> > >      line 18 or whatever, jesus christo, we have to add 47 header
> > >      files to save the thread id somewhere?  this eee structure
> > > seems somewhat unnecessary here, can't we just save it in a
> > > global? [MK] eee seems like a logical place for this variable. We
> > > don't want to create a separate include file for each variable,
> > > do we? I would like to add just one header file, but for some
> > > reason I could not find another way to include that eee.h.
> > 
> > well, how about thread-api.h or esm.h or something like that...
> > probably already included by the files that would actually need this
> > value?
> > [MK] 
> > 
> > Can't be esm.h, this is eee module, esm depends on eee, not the
> > other way around.
> 
> OK, well howz about thread-api.h?
> [MK] 
> Thread api depends on esm which depends on eee.

Oh boy.
