AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755EB50C4A0@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 5 Mar 2010 18:16:19 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: Please review change 34755 -- nighlty build script updates
Message-ID: <20100305181619.64fd03d3@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755EB50C4A0@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755EB50C496@cosmail02.lsi.com>
	<20100305142318.065ebfb4@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755EB50C4A0@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Mar 2010 16:32:03 -0700 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> Your right, I prefer to use the continue command in the loop if P =
> test. Don't know why that didn't occur to me. I use it all the time
> in other scripts. I changed it and the description. I am submitting
> the code with your suggested change.

excellent.

> Larry
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Friday, March 05, 2010 2:23 PM
> To: Scheer, Larry
> Subject: Re: Please review change 34755 -- nighlty build script
> updates
> 
> On Wed, 3 Mar 2010 20:54:56 -0700 "Scheer, Larry"
> <Larry.Scheer@lsi.com> wrote:
> 
> > Change 34755 by larrys@larrys on 2010/03/03 19:35:01 *pending*
> >
> >       Create labels only for products built in a branch. Create the
> > lables based on PRODLIST with the "test" product filtered out of the
> > list. Reviewed by:
> >
> > Affected files ...
> >
> > ... //depot/cm/build_scripts/buildver/nfxbuild.sh#55 edit
> 
> 
> 
> = Change 34755 by larrys@larrys on 2010/03/03 19:35:01 *pending*
> =
> =       Create labels only for products built in a branch. Create the
> lables =       based on PRODLIST with the "test" product filtered out
> of the list. =       Reviewed by:
> =
> 
> 
> 
> build_scripts/buildver/nfxbuild.sh
> 
>      line 704 this is somewhat obtuse.  rather, just for P in ...
>      "if $P = test then continue fi" at the top of the loop would
>      be clearer.  But it's your program.
> 
