AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>,<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E2CC751@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 8 Mar 2010 15:09:49 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Cc: "Fong, Rendell" <Rendell.Fong@lsi.com>
Subject: Re: PERFORCE change 34792 for review
Message-ID: <20100308150949.2e87ef0e@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E2CC751@cosmail02.lsi.com>
References: <WEBMAILDNiSqxwzm8Yo00155727@mail.onstor.com>
	<20100308150249.0ab36cba@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E2CC751@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 8 Mar 2010 16:03:47 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> The stubs were removed, not added. 

Doh!

> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Monday, March 08, 2010 3:03 PM
> To: Kozlovsky, Maxim
> Cc: Fong, Rendell
> Subject: Re: PERFORCE change 34792 for review
> 
> On Mon, 8 Mar 2010 14:30:01 -0700 Maxim Kozlovsky
> <maxim.kozlovsky@lsi.com> wrote:
> 
> > Change 34792 by maximk@maximk-5 on 2010/03/08 13:26:33
> > 
> > 	Add missing functions from the dev branch.
> > 	       Reviewed by rendellf.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-desc.h#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-desc.c#9
> > edit ... //depot/tuxrx/nfx-tree/code/smoo-linux/linux-stubs.c#6 edit
> 
> There's something happening here I don't get: we added blobs for
> eee-desc.h and eee-desc.c, so why did we have to add stubs for these
> functions in linux-stubs.c?
