AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E2601BE@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 9 Mar 2010 09:40:45 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review
Message-ID: <20100309094045.42ed9e09@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E2601BE@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E2601BE@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 5 Mar 2010 11:32:30 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34772 by maximk@maximk-2 on 2010/03/05 10:31:17 *pending*
> 
>         Implement exit function for sm-esm module.
>                Implement mp safe eee_unregisterPollingFunction().
>                Add test for sm-esm.
>                Move esm_execSavedStackPtr inside esm_instance
> structure to avoid the need for CPU_PRIVATE variable.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h#3
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c#10
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c#8
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c#7
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#6
> edit ... //depot/tuxrx/nfx-tree/code/neteee2/eee-poll.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-api.h#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-nfx.c#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.c#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.h#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-tests/Makefile#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-tests/eee-test.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-tests/timer-test.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-tests/anpssctest.c#5 edit
> 



= Change 34772 by maximk@maximk-2 on 2010/03/05 10:31:17 *pending*
= 
= 	Implement exit function for sm-esm module.
= 	       Implement mp safe eee_unregisterPollingFunction().
= 	       Add test for sm-esm.
= 	       Move esm_execSavedStackPtr inside esm_instance structure to 
= 	       avoid the need for CPU_PRIVATE variable.
= 	       Reviewed by andys.
= 

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c

     line 466 ah, the blessed virgin mary

     Just for my own education, I'd like a description of how this
     function works.  I'll stop by your cube unless you'd rather type
     it in ~:^)



linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c

     looks good

nfx-tree/code/neteee2/eee-poll.h

     looks good

nfx-tree/code/sm-esm/esm-api.h

     looks good

nfx-tree/code/sm-esm/esm-nfx.c

     line 196 ooh.  aaah.


nfx-tree/code/sm-esm/esm.c

     line 65 comment doesn't match anything nearby

     line 88-91 indenting of the variables doesn't seem to line up?

     lots of strange whitespace changes in comments, like lines
     265-271 (original lines: 243-249).  adds up to a lot of changes
     in this file.  i'm not sayin'.



nfx-tree/code/sm-esm/esm.h

     looks good

nfx-tree/code/sm-tests/Makefile

     lines 20-23 um, use Larry's new method for generated files instead.
     It'll go in this morning some time.

nfx-tree/code/ssc-tests/anpssctest.c

     line 1431 can we not write any new tests that use sendagile?
     unless it dovetails into RMC, that is.

