AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E2CC9CC@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Mar 2010 09:51:55 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review
Message-ID: <20100310095155.1a5191d5@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E2CC9CC@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E2601BE@cosmail02.lsi.com>
	<20100309094045.42ed9e09@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E2CC9CC@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

OK, rereviewed, comments at bottom.

On Tue, 9 Mar 2010 11:27:18 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> I forgot to add some files to the change, please review them as well,
> here they are:
> 
> ... //depot/tuxrx/nfx-tree/code/sm-tests/sm-test-sm.sm#1 add
> ... //depot/tuxrx/nfx-tree/code/sm-tests/sm-test.c#1 add
> ... //depot/tuxrx/nfx-tree/code/sm-tests/eee-test-2.h#1 edit
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Tuesday, March 09, 2010 9:41 AM
> To: Kozlovsky, Maxim
> Subject: Re: Please review
> 
> On Fri, 5 Mar 2010 11:32:30 -0700 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 34772 by maximk@maximk-2 on 2010/03/05 10:31:17 *pending*
> > 
> >         Implement exit function for sm-esm module.
> >                Implement mp safe eee_unregisterPollingFunction().
> >                Add test for sm-esm.
> >                Move esm_execSavedStackPtr inside esm_instance
> > structure to avoid the need for CPU_PRIVATE variable.
> >                Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c#10
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c#8
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c#7
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#6
> > edit ... //depot/tuxrx/nfx-tree/code/neteee2/eee-poll.h#2 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-api.h#6 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-nfx.c#5 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.c#6 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.h#5 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-tests/Makefile#3 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-tests/eee-test.c#2 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-tests/timer-test.c#2 edit
> > ... //depot/tuxrx/nfx-tree/code/ssc-tests/anpssctest.c#5 edit
> > 
> 
> 
> 
> = Change 34772 by maximk@maximk-2 on 2010/03/05 10:31:17 *pending*
> = 
> = 	Implement exit function for sm-esm module.
> = 	       Implement mp safe eee_unregisterPollingFunction().
> = 	       Add test for sm-esm.
> = 	       Move esm_execSavedStackPtr inside esm_instance
> structure to = 	       avoid the need for CPU_PRIVATE variable.
> = 	       Reviewed by andys.
> = 
> 
> linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c
> 
>      line 466 ah, the blessed virgin mary
> 
>      Just for my own education, I'd like a description of how this
>      function works.  I'll stop by your cube unless you'd rather type
>      it in ~:^)
> [MK] Basically it removes an entry from the polling array. The method
> of argument passing is kind of obfuscated. 
> 
> 
> linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c
> 
>      looks good
> 
> nfx-tree/code/neteee2/eee-poll.h
> 
>      looks good
> 
> nfx-tree/code/sm-esm/esm-api.h
> 
>      looks good
> 
> nfx-tree/code/sm-esm/esm-nfx.c
> 
>      line 196 ooh.  aaah.
> 
> 
> nfx-tree/code/sm-esm/esm.c
> 
>      line 65 comment doesn't match anything nearby
> [MK] it does match
> 
> /* Polling function handle used to unregister.
>  */
> static int32 esm_poll_handle; 
> 
> this is exactly what it is.
> 
>      line 88-91 indenting of the variables doesn't seem to line up?
> [MK] ok
> 
>      lots of strange whitespace changes in comments, like lines
>      265-271 (original lines: 243-249).  adds up to a lot of changes
>      in this file.  i'm not sayin'.
> [MK] I replaced tab with spaces, set your diff tool to ignore white
> space changes.
> 
> 
> 
> nfx-tree/code/sm-esm/esm.h
> 
>      looks good
> 
> nfx-tree/code/sm-tests/Makefile
> 
>      lines 20-23 um, use Larry's new method for generated files
> instead. It'll go in this morning some time.
> 
> nfx-tree/code/ssc-tests/anpssctest.c
> 
>      line 1431 can we not write any new tests that use sendagile?
>      unless it dovetails into RMC, that is.
> [MK] we can, but we'll need to get rmc working first.
> 



= Change 34772 by maximk@maximk-2 on 2010/03/05 10:31:17 *pending*
= 
= 	Implement exit function for sm-esm module.
= 	       Implement mp safe eee_unregisterPollingFunction().
= 	       Add test for sm-esm.
= 	       Move esm_execSavedStackPtr inside esm_instance structure to 
= 	       avoid the need for CPU_PRIVATE variable.
= 	       Reviewed by andys.
= 

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h


     looks good


linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c


     looks good


linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c


     line 466 ah, the blessed virgin mary

     Just for my own education, I'd like a description of how this
     function works.  I'll stop by your cube.



linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c


     looks good


nfx-tree/code/neteee2/eee-poll.h


     looks good


nfx-tree/code/sm-esm/esm-api.h


     looks good


nfx-tree/code/sm-esm/esm-nfx.c


     line 196 ooh.  aaah.



nfx-tree/code/sm-esm/esm.c


     line 65 comment doesn't match anything nearby - maybe you think it
     does, but it doesn't seem to from the point of view of someone who just
     jumped into the code.  to me, deleting the "used to unregister"
     part would actually make more sense.  or, instead, "... passed to
     unregister function".  whatever.


nfx-tree/code/sm-esm/esm.h


     looks good


nfx-tree/code/sm-tests/Makefile


     lines 20-23 um, use Larry's new method for generated files instead.
     It'll go in this morning some time.

     ok


nfx-tree/code/sm-tests/eee-test-2.h

     looks good

nfx-tree/code/sm-tests/sm-test-sm.sm

     >>add nfx-tree/code/sm-tests/sm-test-sm.sm

     lines 7-9 tws (trailing white space)

nfx-tree/code/sm-tests/sm-test.c

     >>add nfx-tree/code/sm-tests/sm-test.c

     could you add some comments at the top of this file: what does
     it test, how does it work (is it loaded into the kernel, or runs
     in userspace or ...)?

nfx-tree/code/ssc-tests/anpssctest.c


     line 1431 can we not write any new tests that use sendagile?
     unless it dovetails into RMC, that is.

     so the test won't work until RMC works.  that's an easy decision
     to make, as it's just one less thing that has to be done to get
     rid of sendAgile, which we are planning to do in tuxstor.


