AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ankur.Kath@lsi.com>,<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	A5E537D8E1B0EF499D49E9AE3E3458FEA4083946@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Mar 2010 11:25:11 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kath, Ankur" <Ankur.Kath@lsi.com>
Cc: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 28178 [ 2-261191501 - SGI] -
 Unable to create volumes with language .utf8 from the GUI
Message-ID: <20100310112511.076aa7da@ripper.onstor.net>
In-Reply-To: <A5E537D8E1B0EF499D49E9AE3E3458FEA4083946@cosmail03.lsi.com>
References: <2B044E14371DA244B71F8BF2514563F53BB0FE79@cosmail03.lsi.com>
	<A5E537D8E1B0EF499D49E9AE3E3458FEA4083946@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Code reviews trump any other assignment.  They are an exercise in time
balancing, because you have to do a decent job checking the changes,
but you can't blow up you're own schedule or the other person's
schedule.  The reviewer is not ultimately responsible for major design
decisions or bugs, but that can play a factor sometimes as
well.  If I were reviewing this change, I would just quickly check to
see if the changes weren't breaking any obvious logic, syntax or
style rules, and if I knew javascript I might try to see if the
changes had a hope-in-heckland of working.  I wouldn't try to figure out
if they are "right" or the best way of making this change, in this case.
Should take you about 5 minutes.

Cheers, and welcome to the team!

a


 On Wed, 10 Mar 2010 12:15:58 -0700 "Kath, Ankur"
<Ankur.Kath@lsi.com> wrote:

> Sure, I should look at it as soon as I am done with my current
> assignment. Is there any timeline associated?
> 
> Thanks,
> Ankur.
> 
> From: Kwan, Ed
> Sent: Wednesday, March 10, 2010 10:59 AM
> To: Kath, Ankur
> Cc: Sharp, Andy
> Subject: RE: please review code change for TED 28178 [ 2-261191501 -
> SGI] - Unable to create volumes with language .utf8 from the GUI
> 
> Hi Ankur,
> 
> Per AndyS, you know javascript.  Can you review my code, as Andy is
> swamped with Tuxstor.
> 
> Thanks,
> Ed
> 
> 
> From: Kwan, Ed
> Sent: Tuesday, March 09, 2010 11:51 PM
> To: Sharp, Andy
> Subject: please review code change for TED 28178 [ 2-261191501 - SGI]
> - Unable to create volumes with language .utf8 from the GUI
> 
> [edk@edk-linux volume]$ p4 describe 34823
> Change 34823 by edk@edk-dev on 2010/03/09 23:47:31 *pending*
> 
>         For TED 28178 [ 2-261191501 - SGI] - Unable to create volumes
> with language .utf8 from the GUI
>         Use the complete list of langauges from
> nfx-tree/code/ssc-nfxsh/fs-lang.h Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-webui/js/volume/add.js#11 edit
