AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E2CCF23@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 10 Mar 2010 15:32:44 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34835
Message-ID: <20100310153244.2536c30c@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E2CCF23@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E2CCF23@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 10 Mar 2010 15:42:09 -0700 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34835 by maximk@maximk-5 on 2010/03/10 14:13:13 *pending*
> 
>         according to libc comments on linux malloc() will attempt to
>                use mmap() if sbrk() fails.
>         mmap() is governed by RMLIMIT_AS instead of RLIMIT_DATA.
>         Set RLIMIT_AS on linux to prevent runaway processes.
>         Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-evm/evm-cfgd.c#20 edit
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-main.c#20 edit
> ... //depot/dev/nfx-tree/code/sm-spm/spm-msg.c#41 edit
> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-api.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-linux.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-openbsd.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cache.c#13
> edit ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#18 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pm.c#25 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pm.h#14 edit
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-daemon.c#67 edit



= Change 34835 by maximk@maximk-5 on 2010/03/10 14:13:13 *pending*
= 
= 	according to libc comments on linux malloc() will attempt to 
= 	       use mmap() if sbrk() fails.
= 	mmap() is governed by RMLIMIT_AS instead of RLIMIT_DATA. 
= 	Set RLIMIT_AS on linux to prevent runaway processes.
= 	Reviewed by andys.
= 

nfx-tree/code/sm-evm/evm-cfgd.c

     looks good

nfx-tree/code/sm-sdm/sdm-main.c

     looks good

nfx-tree/code/sm-spm/spm-msg.c

     looks good

nfx-tree/code/sm-utils/sys-utils-api.h

     stack limit might be a bit small?  i guess some testing needs to
     accompany these changes to see what breaks.

nfx-tree/code/sm-utils/sys-utils-linux.c

     line 112, 117 the way I read the linux man page, and the code,
     rl.rlim_cur and rlim_max should be set to the same value.

nfx-tree/code/sm-utils/sys-utils-openbsd.c

     looks good

nfx-tree/code/ssc-cluster/cluster-contrl-cache.c

     looks good

nfx-tree/code/ssc-nfxsh/vtysh_main.c

     looks good

nfx-tree/code/ssc-pm/pm.c

     looks good

nfx-tree/code/ssc-pm/pm.h

     looks good

nfx-tree/code/ssc-vsd/vs-daemon.c

     looks good

