AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E34B609@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 18 Mar 2010 14:11:12 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: please review 33854
Message-ID: <20100318141112.09981d43@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E34B609@cosmail02.lsi.com>
References: <20100317181902.569f0db4@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E34B609@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 18 Mar 2010 11:53:47 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Time.c:
> 
> 123: If you are ignoring return value, just ignore the return value.
> You can write it like
> 
> 	(void)misc_register(&boon_dog).
> 
> Otherwise it is not clear why you are assigning the result to ret.

fixed

> Sb_wdog.c:
> 
> 79: Comment the constant

it's commented on line 24

> 172: There is still a race here, if the IRQ can be disabled by the
> interrupt handler, you need to disable interrupts here or something.
> Anyway who cares, it is not like that irq handler is doing anything
> useful.

It shouldn't be a race, because the timer isn't activated until line
181.  The interrupt handler could disable it just after I test it, but
that's somebody else's problem.  Stupid hardware doesn't allow you to
ack the interrupt w/o updating the timer...

> 89, 174: I thought sibyte registers were all 64 bit, is it ok to use
> writeb on them?

The manual only shows two bits for this register, unlike all the other
registers -- it doesn't even list the other bits as reserved.  8 bits
is the smallest I can access, so that's what I did.  It works, so....

> 90: I wish you used the register definitions from the header file
> instead of this -0x10 -8. I have no way of finding out if what you
> wrote is correct without lengthy examination of the header files.

fixed.

> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Wednesday, March 17, 2010 6:19 PM
> To: Kozlovsky, Maxim
> Subject: please review 33854
> 
> Change 33854 by andys@ripper on 2009/11/18 13:30:34 *pending*
> 
>         TED00028189 - SiByte Watchdog in danger of initiating system
> reset 
>         Fix some potential race conditions and other bugs in the
> watchdog driver.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/kernel/linux-mips-2.6/arch/mips/onstor/cougar/time.c#2
> edit ... //depot/dev/linux/kernel/linux-mips-2.6/drivers/char/watchdog/sb_wdog.c#5
> edit ... //depot/dev/linux/kernel/linux-mips-2.6/fs/compat_ioctl.c#2
> edit
