AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E3D1B04@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 19 Mar 2010 09:22:41 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 34968
Message-ID: <20100319092241.0b5cbec8@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E3D1B04@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E3D199E@cosmail02.lsi.com>
	<20100318180634.3d0f51e4@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E3D1B04@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Ah, ok.  So recursion is stopped at eee_forwardPacket().  I thought you
were talking about some new bug.

On Fri, 19 Mar 2010 10:04:31 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Previously eee_forwardPacket() will immediately invoke the handling
> routine if the destination was on the same CPU. This could cause a
> recursion, a()->eee_forwardPacket()->b()->eee_forwardPacket()->a()
> again and so on. To avoid this the scsi code had an intermediate
> queue for the packets, so this became
> a()->queue,poll()->eee_forwardPacket()->b()->a(), no recursion. Now I
> moved the queuing into eee_forwardPacket() so no individual module
> needs to worry about recursion.
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Thursday, March 18, 2010 6:07 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review 34968
> 
> On Thu, 18 Mar 2010 17:35:55 -0600 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 34968 by maximk@maximk-4 on 2010/03/18 16:35:06 *pending*
> > 
> >         A queue for scsi responses is no longer necessary, recursion
> >                is now broken at eee_forwardPacket().
> >                Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/nfx-tree/code/sm-scsi/scsi-msg.c#8 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-scsi/scsi.c#8 edit
> > ... //depot/tuxrx/nfx-tree/code/sm-scsi/scsi.h#5 edit
> 
> 
> 
> = Change 34968 by maximk@maximk-4 on 2010/03/18 16:35:06 *pending*
> = 
> = 	A queue for scsi responses is no longer necessary, recursion
> = 	       is now broken at eee_forwardPacket().
> = 	       Reviewed by andys.
> = 
> 
> 
> What does this mean "recursion is now broken at eee_forwardPacket()" ?
> 
> 
> 
> nfx-tree/code/sm-scsi/scsi-msg.c
> 
>      looks ok
> 
> nfx-tree/code/sm-scsi/scsi.c
> 
>      looks good
> 
> nfx-tree/code/sm-scsi/scsi.h
> 
>      looks good
> 
