AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>,<Brian.Stark@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E3D1BD2@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 19 Mar 2010 13:17:59 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Cc: "Stark, Brian" <Brian.Stark@lsi.com>
Subject: Re: prom things in ispfc code
Message-ID: <20100319131759.3eb232ba@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E3D1BD2@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E3D19A9@cosmail02.lsi.com>
	<E1EC65251D4B3D46BBC0AAA3C0629222B23E8500@cosmail02.lsi.com>
	<861DA0537719934884B3D30A2666FECC010E3D19B7@cosmail02.lsi.com>
	<20100318180906.675818ef@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E3D1BD2@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 19 Mar 2010 12:19:26 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Can we make this present tense "The prom code is fixed so you don't
> need to do this"? Say by Monday?

Consider it done now, and comment out this silly code.  If it doesn't
work, we'll know why!

BTW, Brian is out and setting up the HT config registers is likely
going to need to be done by him.  If it isn't actually fixed already,
which would be bizarre, then I can take a shot at it.

> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Thursday, March 18, 2010 6:09 PM
> To: Kozlovsky, Maxim
> Cc: Stark, Brian
> Subject: Re: prom things in ispfc code
> 
> On Thu, 18 Mar 2010 18:28:51 -0600 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > This are not qlogic, but the FP sibyte configuration registers.
> > 
> > 
> > sb1480_ht_cfg_write() writes or reads something at
> > PHYS_TO_XKSEQ_UNCACHED(A_BCM1480_HT_PORT0_HEADER) plus some offset.
> > Since this code was run on FP, this was FP sibyte config register.
> > If I still need to do this, I need to access FP sibyte registers
> > from TXRX.
> 
> Either you don't still need to do this, or the prom code will be fixed
> so you don't.
> 
> 
> > From: Stark, Brian
> > Sent: Thursday, March 18, 2010 5:10 PM
> > To: Kozlovsky, Maxim; Sharp, Andy
> > Subject: Re: prom things in ispfc code
> > 
> > The current PROM allows config cycles from the TXRX all the way down
> > to the QLogics. However, I could not get this to work with function
> > 1 in the QLogic, which is port 1 and 3. I'm not sure why this is the
> > case - it may be an erratum with one of the parts, especially since
> > function 0 works fine.
> > 
> > I'll look at this again tomorrow morning.
> > 
> > What exactly are you trying to target from the TXRX?
> > 
> > 
> > ________________________________
> > From: Kozlovsky, Maxim
> > To: Stark, Brian; Sharp, Andy
> > Sent: Thu Mar 18 17:52:36 2010
> > Subject: prom things in ispfc code
> > 
> > Hello,
> > 
> > Can I read the FP HT configuration registers from TXRX? If not this
> > needs to be added into FP PROM.
> > 
> > Max
> > 
> > From ispfc_pci_init():
> > 
> > 
> >     //@@@ prom workaround -- take out after new prom code is in all
> > systems. // This prom, 'Cougar-prom-1.0.1 : Wed Oct 24 13:48:08
> > 2007', sets the // limit register incorrectly
> >     uint32 reg;
> >     sb1480_ht_cfg_read(5, 1, 0, 0x24, &reg);
> >     if((reg & 0xffff00000) != 0x1f00000) {
> >         printk(" Config error: %x, writing 0x1f00000 to 5, 1, 0 reg
> > 0x24\n", reg); printk(" Prom need to be updated when available\n");
> >         sb1480_ht_cfg_write(5, 1, 0, 0x24, 0x1f00000);
> >     }
> >     //@@@ end of prom workaround
> > 
> >     /* Set maximum read request size to 128 bytes
> >      */
> >     sb1480_ht_cfg_write(6, 0, 0, 0x54, 0x810);
> >     sb1480_ht_cfg_write(6, 0, 1, 0x54, 0x810);
> >     sb1480_ht_cfg_write(7, 0, 0, 0x54, 0x810);
> >     sb1480_ht_cfg_write(7, 0, 1, 0x54, 0x810);
> > 
> > 
