AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E3D1C41@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 19 Mar 2010 14:39:33 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review
Message-ID: <20100319143933.7e8bf909@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E3D1C41@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E3D1C41@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 19 Mar 2010 14:07:16 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 34984 by maximk@maximk-13 on 2010/03/19 13:06:51 *pending*
> 
>         Put ispfc_link_management() routine on a timer. It does not
>                have entry/exit conditions that I can decipher so it is
>                not suitable for being run as polling routine.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-ispfc/ispfc.c#7 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ispfc/ispfc.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ispfc/ispfc_link.c#7 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ispfc/ispfc_link.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ispfc/ispfc_private.h#5 edit
> ... //depot/tuxrx/nfx-tree/code/sm-scsi/scsi.c#9 edit
> 




= Change 34984 by maximk@maximk-13 on 2010/03/19 13:06:51 *pending*
= 
= 	Put ispfc_link_management() routine on a timer. It does not
= 	       have entry/exit conditions that I can decipher so it is 
= 	       not suitable for being run as polling routine.
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-ispfc/ispfc.c

     line 415,707, 717 printk should always have level before format
     string.  KERN_INFO, or KERN_ERR, etc.

nfx-tree/code/sm-ispfc/ispfc.h

     looks good

nfx-tree/code/sm-ispfc/ispfc_link.c

     looks good

nfx-tree/code/sm-ispfc/ispfc_link.h

     looks good

nfx-tree/code/sm-ispfc/ispfc_private.h

     looks good

nfx-tree/code/sm-scsi/scsi.c

     looks good

