AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>,<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1269446397.26360.145.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 24 Mar 2010 11:56:01 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Cc: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: PERFORCE change 35031 for review
Message-ID: <20100324115601.4c3ec72f@ripper.onstor.net>
In-Reply-To: <1269446397.26360.145.camel@rendellf>
References: <201003231910.o2NJA6d8016639@milmhbs0.lsil.com>
	<20100323154623.7718c345@ripper.onstor.net>
	<1269446397.26360.145.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Mar 2010 09:59:57 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> On Tue, 2010-03-23 at 16:46 -0600, Andrew Sharp wrote:
> > On Tue, 23 Mar 2010 13:10:07 -0600 Rendell Fong
> > <rendell.fong@lsi.com> wrote:
> > 
> > > Change 35031 by rendellf@rendellf-test on 2010/03/23 12:09:38
> > > 
> > > 	Assign dummy IP for mgmtbus interface on tuxstor side
> > > during ipmd initialization for IP forwarding purposes.  Skip
> > > flushing mangle table since it won't be used at all.
> > > 	Reviewed by: MaximK
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/tuxrx/nfx-tree/code/sm-ipmd/ipmd.c#6 edit
> > > 
> > > 
> > > http://liszt.onstor.net:1818/@md=d&cd=//depot/$c=G35@/35031?ac=10
> > 
> > line 4423, if you're going to use this macro, then please fix it
> > first.  it's still the same as it was in eee, and tuxstor isn't
> > using that 192.167 borkeness.  i believe i documented the scheme to
> > use in the tuxrx/vsvr design docs i did a while back.
> 
> The macro can be redefined at a later time and its still in use
> elsewhere.  So the code is consistent. 

Exactly.  The later time is now.  There's no reason to have this
brokeness exist for any length of time no matter how short.


