AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>,<brian.stark@lsi.com>,<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E3D26F2@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 24 Mar 2010 14:30:10 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Cc: Brian Stark <brian.stark@lsi.com>, "Fong, Rendell"
 <Rendell.Fong@lsi.com>
Subject: Re: PERFORCE change 35031 for review
Message-ID: <20100324143010.002fcd96@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E3D26F2@cosmail02.lsi.com>
References: <201003231910.o2NJA6d8016639@milmhbs0.lsil.com>
	<20100323154623.7718c345@ripper.onstor.net>
	<1269446397.26360.145.camel@rendellf>
	<20100324115601.4c3ec72f@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E3D2698@cosmail02.lsi.com>
	<20100324130649.725a996f@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E3D26F2@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Mar 2010 14:17:07 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> You need to get the terminology right first, this is not "vsvr"
> design but per virtual server networking stack support, or in short
> virtual stack support. I don't have an objection for you to review if
> the low level networking configuration is done right, but you don't
> have enough back ground to be reviewing the interactions of that code
> with the rest of the virtual server code and the rest of the system.

That's some pretty creative "terminology gerimandering" indeed.  But
this is The vsvr design.  It's the heart of the vsvr body, and like it
or not, most real vsvr code has had to be re-written/re-designed.

You might want to circle some wagons around this or that chunk of code,
I don't care, but this should have been reviewed by me.

Peace, out.


> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com]
> Sent: Wednesday, March 24, 2010 1:07 PM
> To: Kozlovsky, Maxim
> Cc: Fong, Rendell
> Subject: Re: PERFORCE change 35031 for review
>
> I'm completely chilled out.  I'm freezing.  I never said anything
> contradictory to what you said.  All I am saying is let's not let this
> disappear into the mists like it did in the past.
>
> I am also saying that it should have been part of the original
> checkin, which is why I must insist that all vsvr/ related checkins
> be reviewed by me.  I did the new vsvr design and it's my
> responsibility to keep track of how the implementation is following
> that design.
> 
> Please try to comply with this requirement going forward.
> 
> Thanks,
> 
> a
> 
> 
> 
> On Wed, 24 Mar 2010 13:00:43 -0600 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Chill out Andy, I think Rendell should be able to determine the
> > order in which it is easier for him to do the changes. There is no
> > reason to do everything at once.
> > 
> > -----Original Message-----
> > From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> > Sent: Wednesday, March 24, 2010 11:56 AM
> > To: Fong, Rendell
> > Cc: Kozlovsky, Maxim
> > Subject: Re: PERFORCE change 35031 for review
> > 
> > On Wed, 24 Mar 2010 09:59:57 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > On Tue, 2010-03-23 at 16:46 -0600, Andrew Sharp wrote:
> > > > On Tue, 23 Mar 2010 13:10:07 -0600 Rendell Fong
> > > > <rendell.fong@lsi.com> wrote:
> > > > 
> > > > > Change 35031 by rendellf@rendellf-test on 2010/03/23 12:09:38
> > > > > 
> > > > > 	Assign dummy IP for mgmtbus interface on tuxstor side
> > > > > during ipmd initialization for IP forwarding purposes.  Skip
> > > > > flushing mangle table since it won't be used at all.
> > > > > 	Reviewed by: MaximK
> > > > > 
> > > > > Affected files ...
> > > > > 
> > > > > ... //depot/tuxrx/nfx-tree/code/sm-ipmd/ipmd.c#6 edit
> > > > > 
> > > > > 
> > > > > http://liszt.onstor.net:1818/@md=d&cd=//depot/$c=G35@/35031?ac=10
> > > > 
> > > > line 4423, if you're going to use this macro, then please fix it
> > > > first.  it's still the same as it was in eee, and tuxstor isn't
> > > > using that 192.167 borkeness.  i believe i documented the scheme
> > > > to use in the tuxrx/vsvr design docs i did a while back.
> > > 
> > > The macro can be redefined at a later time and its still in use
> > > elsewhere.  So the code is consistent. 
> > 
> > Exactly.  The later time is now.  There's no reason to have this
> > brokeness exist for any length of time no matter how short.
> > 
> > 
