AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E3D2586@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 24 Mar 2010 14:42:34 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review 35039
Message-ID: <20100324144234.1b39ec81@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E3D2586@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E3D2586@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Mar 2010 10:11:38 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Change 35039 by maximk@maximk-3 on 2010/03/24 09:09:55 *pending*
> 
>         Fix the esm assembly to use 64 bit ops everywhere.
>                ESM stack size must match the kernel thread stacks and
> stacks should have the thread_info structure at the bottom same as
>                kernel threads.
>                Delete unused code.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/code/sm-esm/Makefile#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-api.h#7 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-nfx-thread.S#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-nfx.c#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-stack.c#2 delete
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.c#7 edit
> ... //depot/tuxrx/nfx-tree/code/sm-esm/esm.h#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-tests/Makefile#6 edit
> ... //depot/tuxrx/nfx-tree/code/sm-tests/sm-thread-test.c#1 add
> ... //depot/tuxrx/nfx-tree/code/ssc-x86-tests/Makefile#7 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-x86-tests/smthreadtest.c#1 add



= Change 35039 by maximk@maximk-3 on 2010/03/24 09:09:55 *pending*
= 
= 	Fix the esm assembly to use 64 bit ops everywhere.
= 	       ESM stack size must match the kernel thread stacks and stacks 
= 	       should have the thread_info structure at the bottom same as
= 	       kernel threads.
= 	       Delete unused code.
= 	       Reviewed by andys.
= 

nfx-tree/code/sm-esm/Makefile

     ok

nfx-tree/code/sm-esm/esm-api.h

     ok

nfx-tree/code/sm-esm/esm-nfx-thread.S

     looks ok

nfx-tree/code/sm-esm/esm-nfx.c

     looks good

nfx-tree/code/sm-esm/esm-stack.c

     >>delete nfx-tree/code/sm-esm/esm-stack.c

nfx-tree/code/sm-esm/esm.c

     looks good

nfx-tree/code/sm-esm/esm.h

     looks good

nfx-tree/code/sm-tests/Makefile

     looks good

nfx-tree/code/sm-tests/sm-thread-test.c

     >>add nfx-tree/code/sm-tests/sm-thread-test.c

nfx-tree/code/ssc-x86-tests/Makefile

     looks good

nfx-tree/code/ssc-x86-tests/smthreadtest.c

     >>add nfx-tree/code/ssc-x86-tests/smthreadtest.c

