AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Maxim.Kozlovsky@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	861DA0537719934884B3D30A2666FECC010E4403F8@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 29 Mar 2010 14:52:36 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>
Subject: Re: Please review
Message-ID: <20100329145236.70ed649e@ripper.onstor.net>
In-Reply-To: <861DA0537719934884B3D30A2666FECC010E4403F8@cosmail02.lsi.com>
References: <861DA0537719934884B3D30A2666FECC010E4402BD@cosmail02.lsi.com>
	<20100329132957.165abeb9@ripper.onstor.net>
	<861DA0537719934884B3D30A2666FECC010E4403F8@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 35111 by maximk@maximk-8 on 2010/03/29 10:47:17 *pending*
= 
= 	Fix compilation, remove netrmc.
= 	       Reviewed by andys.
= 

linux/kernel/linux-mips-2.6/net/Kconfig

     looks good - is neteee/Kconfig deleted from the branch?

linux/kernel/linux-mips-2.6/net/neteee/neteee.c

     looks good

linux/kernel/linux-mips-2.6/tuxstor-config


     looks good


linux/kernel/linux-mips-2.6/tuxstor-debug-config


     line 316-320 have you confirmed that both the kernel and
     out-of-tree code compiles with these being changed to m?  I was
     under the impression that areas like TPL, NETEEE2, etc didn't
     really work when built as modules.





On Mon, 29 Mar 2010 15:09:06 -0600 "Kozlovsky, Maxim"
<Maxim.Kozlovsky@lsi.com> wrote:

> Ok removed from kconfig file
> 
> Change 35111 by maximk@maximk-8 on 2010/03/29 10:47:17 *pending*
> 
>         Fix compilation, remove netrmc.
>                Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Kconfig#5 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#9
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#8
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#7
> edit
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Monday, March 29, 2010 1:30 PM
> To: Kozlovsky, Maxim
> Subject: Re: Please review
> 
> On Mon, 29 Mar 2010 11:47:51 -0600 "Kozlovsky, Maxim"
> <Maxim.Kozlovsky@lsi.com> wrote:
> 
> > Change 35111 by maximk@maximk-8 on 2010/03/29 10:47:17 *pending*
> > 
> >         Fix compilation, remove netrmc.
> >                Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#8 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#7
> > edit
> > 
> 
> 
> 
> = Change 35111 by maximk@maximk-8 on 2010/03/29 10:47:17 *pending*
> = 
> = 	Fix compilation, remove netrmc.
> = 	       Reviewed by andys.
> = 
> 
> linux/kernel/linux-mips-2.6/tuxstor-config
> linux/kernel/linux-mips-2.6/tuxstor-debug-config
> 
>      CONFIG_NETRMC shouldn't be in the config file at all if it
> doesn't exist anymore.  I can't easily check, but it should also have
>      been removed from the Kconfig file.  In that case, this line
>      should just be deleted as opposed to commented out.
> 
