AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Pravin.Shedage@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	04FB0DCDF7702C409F7E481C74E6A9BF020F99E2DD@inbmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 1 Apr 2010 11:21:50 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Shedage, Pravin" <Pravin.Shedage@lsi.com>
Subject: Re: Please review the changes for defect TED00028036.
Message-ID: <20100401112150.506e8fe6@ripper.onstor.net>
In-Reply-To: <04FB0DCDF7702C409F7E481C74E6A9BF020F99E2DD@inbmail02.lsi.com>
References: <04FB0DCDF7702C409F7E481C74E6A9BF020F99E2DD@inbmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Pravin,

Please just send me a changelist # that contains the change.  Part of
the review process is to review the checkin comments, so you should
create a changelist for just this change, and put in the checkin
comments you intend to use.  After that, all I need is the changelist #
in question, and I can take it from there.

Thanks,

a


On Thu, 1 Apr 2010 01:10:58 -0600 "Shedage, Pravin"
<Pravin.Shedage@lsi.com> wrote:

> Hi Andy,
> 
>    Please review the changes for defect TED00028036.
> 
> Problem Description:
>    CLI "nfs share modify": doesn't check for valid IP for client list.
> 
> Testing:
>    I tested "nfs share modify" for following reserved ip addresses.
>    - "0.0.0.0"
>    - "127.0.0.1"
>    - "255.255.255.255"
> 
> View Changes:
>    - To view changes use following steps
>    1. P4CLIENT=pravin1
>    2. P4CLIENT=pravin1 p4
> diff /homes/pshedage/pravin1/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> 
> Changed files:
>    //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> 
> 
>    Thanks,
> Pravin Shedage.