AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E022157C5@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 14 May 2007 16:23:21 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Request for Review 2 (Samba)
Message-ID: <20070514162321.4b640bcf@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E022157C5@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E022157C5@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 14 May 2007 12:30:59 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
> 	These are my Samba changes. My work space is
> /homes/larrys/perforce/trees/cougar.
> 
> I am renaming config.h to openbsd.h. After this check-in I need to add
> back in config.h which will just look like this:
> #include OS_INCL
> 
> I am adding linux.h which is config.h as created by the configure
> command.
> 
> Change 23934 by larrys@larrys-verify-depot on 2007/05/10 15:59:39
> *pending*
> 
>         Samba 3.0.21a port for bobcat Linux.
> 
> Affected files ...
> 
> ... //depot/cougar/nfx-tree/code/samba-3.21a/Makefile#3 edit
> ... //depot/cougar/nfx-tree/code/samba-3.21a/include/config.h#1 delete
> ... //depot/cougar/nfx-tree/code/samba-3.21a/include/linux.h#1 add
> ... //depot/cougar/nfx-tree/code/samba-3.21a/include/openbsd.h#1
> branch ... //depot/cougar/nfx-tree/code/samba-3.21a/passdb/secrets.c#4
> edit

nfx-tree/code/samba-3.21a/Makefile

     you know I don't want to see any ifdefs, which includes ifeq() in
Makefiles please replace these with the standard method for handling
this shiite 
     line 1811, why did you @-out this link command? it really
shouldn't be.

nfx-tree/code/samba-3.21a/include/config.h

     ok
     delete nfx-tree/code/samba-3.21a/include/config.h

nfx-tree/code/samba-3.21a/passdb/secrets.c

     looks good

