AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E022157C6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 14 May 2007 16:32:46 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review request
Message-ID: <20070514163246.2092fdc5@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E022157C6@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E022157C6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 14 May 2007 12:40:22 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>      These changes are pretty straight forward. I am just including
> tool-chain-pk.mk so users can run make install_toolchain at various
> levels in the hierarchy and turning on the clean targets for the
> kernel which were previously commented out.
> 
> Let me know if I need to change the clean targets.
> 
> Change 23935 by larrys@larrys-verify-depot on 2007/05/10 16:00:43
> *pending*
> 
>         Changes to help with Kernel build, enable clean target.
> 
> Affected files ...
> 
> ... //depot/cougar/Makefile#3 edit
> ... //depot/cougar/linux/Makefile#2 edit
> ... //depot/cougar/linux/kernel/Makefile#2 edit

Makefile

     PATH_TO_LINUX obviosly not needed, so why have it there?
     anyway, it shouldn't be like that even if it should be
     there, it should be $(OS) not $(PATH_TO_LINUX)

linux/Makefile

     PATH_TO_LINUX again, shouldn't be here

linux/kernel/Makefile

     make the CONV assignment conditional:
     
     	CONV ?= /usr/local/sde4/bin/conv
     
     Please leave the clean target commented out for now, it's not
tested and likely to do bad things.  It's not what I want, I just put
it there as a place holder.
     

